generated from ryanatkn/fuz_template
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add create_context
helper
#56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update: refined the API in #57
Adds a
create_context
helper for better ergonomics withgetContext
/setContext
.See
github.com/sveltejs/svelte/issues/8941
(ugh this backlink-spammed the Svelte issue, sigh, it didn't linkifygit.luolix.top/sveltejs/svelte
omitting thehttps://
so I then addedissues/8941
and it did linkify, creating a spammy backlink - wrapping with backticks seems to be the best option here,<>
doesn't help)I originally tried a class implementation but it has some type limitations that the function
create_context
does not have because it leverages overloaded function signatures.Examples: (notice the subtle type differences)
I originally included an optional
label
to error messages, but it's not relevant if afallback
is provided other than being added to the context key symbol, which may not do anything useful.Fixed the
error_message
type here - 56462f9 - since it's only valid in the fallbackless/nonoptional case.Followup:
error_message
?This PR also cleans up some stuff that was moved to Moss - some of these related things will probably be published as components later.