Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Filer to resolve node modules #512

Merged
merged 27 commits into from
Oct 26, 2024
Merged
5 changes: 5 additions & 0 deletions .changeset/chilled-houses-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@ryanatkn/gro': minor
---

fix `Filer` to resolve node modules
8 changes: 2 additions & 6 deletions gro.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// TODO see below
// import {gro_plugin_moss} from '@ryanatkn/moss/gro_plugin_moss.js';
import {gro_plugin_moss} from '@ryanatkn/moss/gro_plugin_moss.js';

import {create_empty_gro_config} from './src/lib/gro_config.js';
import {gro_plugin_sveltekit_library} from './src/lib/gro_plugin_sveltekit_library.js';
Expand All @@ -15,10 +14,7 @@ import {gro_plugin_gen} from './src/lib/gro_plugin_gen.js';
const config = create_empty_gro_config();

config.plugins = () => [
// TODO how to do this? moss imports gro, so it needs to exist in node_modules,
// maybe the fix is to add an exception for gro in the loader if the project is gro?
// would still need to hack the type I guess but that's fine?
// gro_plugin_moss(),
gro_plugin_moss() as any, // TODO hack around self imports, Moss is importing into Gro (maybe extract `format_file` etc)
gro_plugin_sveltekit_library(),
gro_plugin_sveltekit_app(),
gro_plugin_gen(),
Expand Down
Loading
Loading