Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terradrift.com [Breakage] [FETL] #648

Closed
kulfoon opened this issue Nov 11, 2018 · 12 comments
Closed

terradrift.com [Breakage] [FETL] #648

kulfoon opened this issue Nov 11, 2018 · 12 comments

Comments

@kulfoon
Copy link

kulfoon commented Nov 11, 2018

List the website(s) you're having issues:

https://terradrift.com/

What happens?

Breakage - the page won't load - shadow overlay (after closing anti-adblock message).

List Subscriptions you're using:

uBO default +
uBO annoyance +
Fanboy’s Enhanced Tracking List

Your settings

  • OS/version: Windows 7 SP1 64bit
  • Browser/version: Firefox 63.0.1 64bit / Opera 56 64bit
  • Adblock Extension/version: uBlock Origin version: 1.17.2

Other details:

Screenshoots:

screenshoot 1 - the anti-adblock message with or without enabling Fanboy’s Enhanced Tracking List

ss_018

.
screenshoot 2 - after enabling Fanboy’s Enhanced Tracking List + after accepting the anti-adblock message

ss_020

.
screenshoot 3 - after disabling Fanboy’s Enhanced Tracking List + after accepting the anti-adblock message

ss_019

@THEtomaso
Copy link

THEtomaso commented Nov 11, 2018

A simple $generichide takes care of the adblock warning:
@@||terradrift.com^$generichide

It also needs a rule to get rid of the nag about blocking some of their so-called "features".
This generic rule (added by ryanbr yesterday) doesn't work in this particular case:
easylist/easylist@290afa8
This is probably because of a timing issue, which is explained by gorhill here:
gorhill/uBlock#1885 (comment)
..so the rule needs to be site-specific, like this:
terradrift.com###the_champ_sharing_more_providers
The issue is browser/extension dependent, also explained by gorhill here:
uBlockOrigin/uAssets#3389 (comment)

As for the shadow overlays that you've been reporting for various sites; I tried a few proxies, but I'm still not able to reproduce them.
They must be very location-specific.

@kulfoon
Copy link
Author

kulfoon commented Nov 11, 2018

Most probably you are aware of it already like most of experienced people, but just for make sure, do you clear both browser's cookies & cache before trying to reproduce the shadow overlay issues? As they can be reproduced in most cases only the first fresh time you visit website.

Also to provide more info abut the overlay shadow I've made a screenshoot with uBO element picker:

terradrift.com shadow overlay screenshoot

ss_034

.

and

the uBO logger screenshoots

ss_038
ss_037
ss_036
ss_035

@THEtomaso
Copy link

do you clear both browser's cookies & cache before trying to reproduce the shadow overlay issues?

Yes, of course.
I also tried to disable a bunch of filters, which you're not using.
And I looked in uBO's logger to see if I could find it there.

@kulfoon
Copy link
Author

kulfoon commented Nov 11, 2018

I've updated my comment above with uBO logger screenshoots, can they help to solve the issue? If not what can I else do to help to reproduce?

@THEtomaso
Copy link

I'm connecting from Norway.
I also tried to connect from Germany, Netherlands and USA, using the free proxies here:
https://hide.me/en/proxy/
Still no overlays.

How about from your end?
Does the overlays disappear when you connect through those proxies?

@kulfoon
Copy link
Author

kulfoon commented Nov 11, 2018

I've tried Browsec https://browsec.com/en/ as an browser extension:
https://chrome.google.com/webstore/detail/browsec-vpn-free-and-unli/omghfjlpggmjjaagoclmmobgdodcjboh
https://addons.mozilla.org/pl/firefox/addon/browsec/

Browsec screenshoot

ss_039

.

with all 4 free vpn proxies (Netherlands, Singapore, United Kingdom, United States) and still can reproduce on all of them.

I've even restored uBO to default settings, updated all the filter lists and still do reproduce.

@THEtomaso
Copy link

Weird!

When connecting through proxies, I saw references to hotjar.com..
What happens if you block it, like this?:
hotjar.com$important,domain=terradrift.com

@kulfoon
Copy link
Author

kulfoon commented Nov 11, 2018

Nothing, still no change, can you tell me what filter (in uBO logger) does block the shadow overlay for you? As seen from the uBO element picker screenshoot as per #648 (comment) it says that the overlay shadow is either:
||terradrift.com/wp-content/plugins/super-socializer/images/transparent_bg.png or
###heateor_ss_browser_popup_bg

Or maybe for you it isn't even blocked by any filter because there is no overlay shadow served at all for you?

EDIT: no dom filters matching #heateor_ss_browser_popup_bg in my uBO logger (as per the uBO logger screenshoots from #648 (comment)) and there is an unblocked request to:
13:37:31 image | https://terradrift.com/wp-content/plugins/super-socializer/images/transparent_bg.png

@THEtomaso
Copy link

THEtomaso commented Nov 11, 2018

OK, I think that I might have found the problem now..
Like I pointed out in one of my earlier posts; terradrift.com is affected by a timing issue, described by gorhill.
At my end, I didn't see the overlays, because 'Fanboy's Annoyance List' and 'Fanboy's Social Blocking List' blocked it, with the following rule:
/plugins/super-socializer/*
..but at your end, the timing issue probably renders the generic rule useless (although, I thought it only affected cosmetic filters).

So, what happens if you make that rule site-specific, like this?:
/plugins/super-socializer/*$domain=terradrift.com
Does this fix the problem at your end?

--

EDIT:
OK, scratch that.
I see that you're only using 'Fanboy’s Enhanced Tracking List'
LOL!
That explains it! :)

@kulfoon
Copy link
Author

kulfoon commented Nov 11, 2018

THEtomaso : At my end, I didn't see the overlays, because 'Fanboy's Annoyance List' and 'Fanboy's Social Blocking List' blocked it, with the following rule:
/plugins/super-socializer/*

As you can see the title of the issue is:

terradrift.com [Breakage] [FETL]

FETL = Fanboy's Enhanced Tracking List

And my filter list set is:

uBO default +
uBO annoyance +
Fanboy’s Enhanced Tracking List

And the content of the 1st comment also mentions only Fanboy's Enhanced Tracking List.

I nowhere have mentioned about other Fanboy's lists...

I don't have the shadow overlay if 'Fanboy's Annoyance List' or 'Fanboy's Social Blocking List' enabled.

So it seems that you've made a mistake by trying to reproduce the issue with wrong filter lists enabled.

@THEtomaso
Copy link

Indeed.
I read your first post too fast, and assumed that you were using 'Fanboy's Annoyance List' and 'Fanboy's Social Blocking List'.
Those were the filters that I tested it against. :)

@THEtomaso
Copy link

THEtomaso commented Nov 11, 2018

Summary (so ryanbr won't have to read through everyting):

Affected site:

https://terradrift.com/

Issues:

  • Anti-adblock message
  • Shadow overlay
  • Nag message (about blocked features)

Possible fix:

@@||terradrift.com^$generichide
/favicon.ico$image,third-party,domain=~terradrift.com
terradrift.com###the_champ_sharing_more_providers

Notes:

  • /favicon.ico$image,third-party,domain=~terradrift.com is needed for 'Fanboy's Enhanced Tracking List', since this is the very blocking rule that is causing the overlay.
    Alternatively, this rule (found in 'Fanboy's Annoyance List' and 'Fanboy's Social Blocking List') also kills the overlay:
    /plugins/super-socializer/*
    ..but I guess that type of rule should be reserved for those filters?

  • terradrift.com###the_champ_sharing_more_providers is needed for 'Fanboy's Enhanced Tracking List', since the existing generic rule doesn't work for all browsers.
    This is because of a rare timing issue, explained by gorhill here:
    Bug: Filters containing classes with double dashes are ignored gorhill/uBlock#1885 (comment)
    I've only encountered this issue once before.
    The other place is @ gaming.youtube.com.
    I reported it for 'EasyList' more than two months ago, here:
    YouTube Gaming - Ad markers easylist/easylist#1778
    ..but it still remains unfixed!

ryanbr added a commit that referenced this issue Dec 1, 2018
@ryanbr ryanbr closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants