Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fieldParser arguments to be optional #54

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

andyhqtran
Copy link
Contributor

Summary

Since there are already default values defined for props and options, there's no need to require them.

image

Changes

Updated the props and options in fieldsParser types to be optional.

Notes

Awesome package btw, going to reduce our overall file size significantly! 😄

Copy link
Owner

@ryanhefner ryanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@ryanhefner ryanhefner merged commit f239183 into ryanhefner:master Oct 2, 2020
@ryanhefner
Copy link
Owner

Thanks @andyhqtran, those updates are live now. Glad it's working well for you!

@andyhqtran
Copy link
Contributor Author

Thanks @andyhqtran, those updates are live now. Glad it's working well for you!

Awesome thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants