Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue 1016 #1017

Open
wants to merge 1 commit into
base: minor
Choose a base branch
from
Open

fixing issue 1016 #1017

wants to merge 1 commit into from

Conversation

mhassan772
Copy link

@mhassan772 mhassan772 commented May 3, 2023

This change here is fixing the 1016 issue. #1016
It is basically solving the problem based on this guidance here: https://developer.apple.com/forums/thread/654413

Pre-launch Checklist

  • I read the CONTRIBUTING.md and followed the process outlined there for submitting PRs.
  • My change is not breaking and lands in minor branch OR my change is breaking and lands in major branch.
  • If I'm the first to contribute to the next version, I incremented the version number in pubspec.yaml according to the pub versioning philosophy.
  • [I couldn't find it ] I updated CHANGELOG.md to add a description of the change (format: * DESCRIPTION OF YOUR CHANGE (@mhassan772)).
  • I updated/added relevant documentation (doc comments with ///).
  • I ran dart analyze.
  • I ran dart format.
  • I ran flutter test and all tests are passing.

It is a very minor change

@838
Copy link

838 commented Aug 21, 2023

@mhassan772
Thanks for the fix.

@ryanheise
We really want to merge this fix to our fork version of audio_service. Could the code has any side effect?

@ryanheise
Copy link
Owner

I am reviewing this PR now, thanks.

@mhassan772
Copy link
Author

How did the review go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants