Rename enums for clarity and pep8 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
approved these changes
Jul 24, 2024
ryanhiebert
force-pushed
the
rename-enums
branch
from
570ddee
to
3de2104
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 188 185 -3
Branches 43 42 -1
=========================================
- Hits 188 185 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is not urgent. IMO, it would be fine to release this in a minor version upgrade.
PEP 8 spoke that we should use ALL_CAPS for enum values, but I was too stubborn to get on board. In this I hope to lower my stubbornness by switching this in these internal APIs. And rename our enums to have a bit clearer semantic meaning that I hope will be easier to digest.