Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default to Safe.always #64

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Change the default to Safe.always #64

merged 1 commit into from
Jul 25, 2024

Conversation

ryanhiebert
Copy link
Owner

Fix #38

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (442336b) to head (f10caaa).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          188       188           
  Branches        42        42           
=========================================
  Hits           188       188           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this combined with the pre-commit check.

I think the test I commented on should be cleaned up with either approach (rename test or change migration plan). I'm not worried about it though.

@ryanhiebert ryanhiebert merged commit 0f1a375 into main Jul 25, 2024
16 checks passed
@ryanhiebert ryanhiebert deleted the default-always branch July 25, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default
2 participants