Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with documented prior API #65

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add compatibility with documented prior API #65

merged 1 commit into from
Jul 25, 2024

Conversation

ryanhiebert
Copy link
Owner

In addition to just providing compatibility with the old API, I want the old API to still be the preferred documented API, so I changed some language in the history and reverted the readme examples to the old api.

Fix #54

@tim-schilling
Copy link
Collaborator

I want the old API to still be the preferred documented API

This is not what I would do mainly because I'd prefer to only have 1 way to do things. I don't see the benefit to the library from a technical perspective. There is a DX benefit of having fewer keystrokes, but eh. It's not a frequent occurrence.

Is there a justification I'm missing?

@ryanhiebert
Copy link
Owner Author

ryanhiebert commented Jul 25, 2024

The benefit I'm valuing most is the clear signal that we haven't and do not intend to break the prior documented API. I'd agree with you to prefer consistency if we weren't dealing with compatibility. You are the lead maintainer, so if you don't care about that signal, or if you think we should expect to break compatibility here at some point in the future, then I'll drop that part of this PR. This is my preference, but no choice is a bad one.

@tim-schilling
Copy link
Collaborator

Ah gotcha. Right now, I'm fine with changing APIs when there's a clear and easy migration process. I'll revisit this after the weekend to see if that changes.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f1a375) to head (c4ab76f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          188       190    +2     
  Branches        42        42           
=========================================
+ Hits           188       190    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanhiebert ryanhiebert merged commit 79a4860 into main Jul 25, 2024
16 checks passed
@ryanhiebert ryanhiebert deleted the compat branch July 25, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support backwards compatibility with Safe.before_deploy attributes
2 participants