Show when a seen delayed migration can be run #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 190 192 +2
Branches 42 43 +1
=========================================
+ Hits 190 192 +2 ☔ View full report in Codecov by Sentry. |
tim-schilling
approved these changes
Jul 26, 2024
I avoided pulling in a dependency on something like freezegun by giving a delay with a buffer of 10 minutes.
ryanhiebert
force-pushed
the
seen-delayed-output
branch
from
6d87c80
to
3780319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation always shows the delay starting from "now" rather than from when the migration was first detected.
I avoided pulling in a dependency on something like freezegun by giving a delay with a buffer of 10 minutes.