Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to fix nonidempotency #60

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

FishmanL
Copy link
Contributor

@FishmanL FishmanL commented Feb 2, 2021

Fixes #59

Copy link
Owner

@ryanhiebert ryanhiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll try to get that released shortly. I'm rusty on what my release process is for this repo.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #60 (9a9241f) into main (665217e) will increase coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   55.55%   55.66%   +0.10%     
==========================================
  Files          11       11              
  Lines         423      424       +1     
==========================================
+ Hits          235      236       +1     
  Misses        188      188              
Impacted Files Coverage Δ
hirefire/procs/__init__.py 72.09% <50.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665217e...9a9241f. Read the comment docs.

@ryanhiebert ryanhiebert merged commit 0cd2503 into ryanhiebert:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_procs should warn rather than erroring if a proc with a duplicate name is loaded
2 participants