Pass arguments to the Blueprint constructor in the correct order #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Flask API documentation, the
Blueprint
constructor expects to receivename
as its first argument andimport_name
as its second argument.It looks like there is a typo in the existing HireFire code, as
__name__
—a suitable value forimport_name
—is passed as the first argument, while the string"hirefire"
—a suitable value forname
—is passed as the second argument. In other words, the order in which the first two arguments are passed is reversed.This part of the Flask API was unaffected by the upgrade from Flask 1.x.x to 2.x.x, but Flask 2.x.x will raise the following exception when it notices that the HireFire blueprint's name contains a dot (
.
):In this PR, I switch the order of the first two arguments to the
Blueprint
constructor.