Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: #[inline] small functions #655

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Liamolucko
Copy link

I've added #[inline] to a bunch of small functions. This about doubled my project's framerate, specifically due to Vector math.

Also, the crate was failing to compile due to #[deprecated] being placed on some impl blocks, which seems to be invalid.
I was getting this error:

error: this `#[deprecated]` annotation has no effect
   --> src/geom/shape.rs:224:1
    |
224 | / #[deprecated(
225 | |     since = "0.4.0-alpha0.5",
226 | |     note = "Use another collision library like `vek` instead; please comment on issue #552 for use-cases other libraries don't solve"
227 | | )]
    | |__^ help: remove the unnecessary deprecation attribute
    |
    = note: `#[deny(useless_deprecated)]` on by default

Checks

  • I have updated CHANGES.md, with [BREAKING] next to all breaking changes
  • I have updated the documentation if necessary
  • If 01_square example was changed, src/lib.rs and README.md were updated

@ryanisaacg
Copy link
Owner

It looks like CI is failing, may be because the CI itself is out of date.

@lenscas
Copy link
Contributor

lenscas commented Feb 7, 2021

It looks like CI is failing, may be because the CI itself is out of date.

it is:

The add-path command is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants