Skip to content

Commit

Permalink
ComicShanns: Fix carons
Browse files Browse the repository at this point in the history
[why]
The carons are all upside down.
The dcaron and tcaron should use an 'apothrophe'.

[how]
The simplify the fixing of all carons we take the excellent fork ofu
Rodrigo Batista de Moraes that (re?)creates the letters with caron from
references.

Just manually flip the caron and all combined glyphs will be fixed.

Create a combining-comma-above-right from the ordinary comma.

Reference that for dcaron and tcaron.

Rerun `make-bold` which creates the two otf files.

Fixes: #1492

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
  • Loading branch information
Finii committed Mar 18, 2024
1 parent 5fea300 commit 98bcb3a
Show file tree
Hide file tree
Showing 6 changed files with 13,639 additions and 2 deletions.
Binary file modified src/unpatched-fonts/ComicShannsMono/ComicShannsMono-Bold.otf
Binary file not shown.
Binary file modified src/unpatched-fonts/ComicShannsMono/ComicShannsMono-Regular.otf
Binary file not shown.
Binary file not shown.
13,634 changes: 13,634 additions & 0 deletions src/unpatched-fonts/ComicShannsMono/ComicShannsMono-Regular.sfd_modified

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion src/unpatched-fonts/ComicShannsMono/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ For more information have a look at the upstream website: https://github.com/jes

* Nerd Fonts corrects some issues of the font
* The font is based on _Comic Shanns v2_ by Shannon Miwa (https://github.com/shannpersand/comic-shanns)
* The excellent fork with references by Rodrigo Batista de Moraes is used instead (https://github.com/jesusmgg/comic-shanns-mono/pull/7, https://github.com/Rodrigodd/comic-shanns-mono)
* The caron is corrected (vertically mirrored) by Nerd Fonts
* dcaron and tcaron are corrected with apothrophe by Nerd Fonts
* The **Bold** weight has been manually added by Nerd Fonts, inspired by Thai Pangsakulyanont's _Comic Mono_ (https://github.com/dtinth/comic-mono-font)

Version: 1.3
Version: 1.3.1
2 changes: 1 addition & 1 deletion src/unpatched-fonts/ComicShannsMono/make_bold
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

import fontforge

font = fontforge.open('ComicShannsMono-Regular.otf_orig')
font = fontforge.open('ComicShannsMono-Regular.sfd_modified')

# Repair some issues in source
font.selection.all()
Expand Down

0 comments on commit 98bcb3a

Please sign in to comment.