Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher overrides Fira Code progress bars and spinners in fonts #1593

Closed
3 tasks done
AlexKurisu opened this issue Apr 7, 2024 · 7 comments · Fixed by #1596
Closed
3 tasks done

Patcher overrides Fira Code progress bars and spinners in fonts #1593

AlexKurisu opened this issue Apr 7, 2024 · 7 comments · Fixed by #1596
Milestone

Comments

@AlexKurisu
Copy link

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
Patcher overrides Fira Code progress bars and spinners with Font Awesome icons, causing compatibility issues in terminals that have already implemented custom box-drawing for them and also with software that has support for those symbols as progress bars and spinners.

Expected behavior:
Nerd Fonts patcher should not override those symbols.

Example symbols:
U+EE00-U+EE0B (            )

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • IosevkaTermNerdFont-{Regular,Bold,Italic}.ttf
  • Where did you get the file from (download link, self patched, source downloaded from link...)
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    • Wezterm, Kitty
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    • Arch Linux

★ Screenshots (Optional)

image
image

@AlexKurisu
Copy link
Author

In release 3.1.1, IosevkaTerm Nerd Font had support for Fira Code progress bars, btw

@Finii
Copy link
Collaborator

Finii commented Apr 7, 2024

Ugg, that is not good news.

in terminals that have already implemented custom box-drawing for them and also with software that has support for those symbols as progress bars and spinners

Can you list some and maybe show (with an old font) what they do?

@Finii
Copy link
Collaborator

Finii commented Apr 7, 2024

@AlexKurisu
Copy link
Author

AlexKurisu commented Apr 7, 2024

Can you list some and maybe show (with an old font) what they do?

Well, i have only one, and it is patched pacman package manager:
image
This is how it looks in kitty:
image
And this is how new Font Awesome symbols that replace them look in kitty:
image

@Finii Finii added this to the v3.2.1 milestone Apr 8, 2024
@Finii Finii mentioned this issue Apr 8, 2024
2 tasks
@Finii
Copy link
Collaborator

Finii commented Apr 8, 2024

Will be fixed with #1596

@Finii
Copy link
Collaborator

Finii commented Apr 9, 2024

and it is patched pacman package manager

Can you give instructions how and what 'patched' means? :->

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants