-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FontAwesome: Update to 6.5.1 #1563
Conversation
f718fa5
to
b9d12cb
Compare
b9d12cb
to
4e318d3
Compare
We specifically use the SVGs to create the intermediate carrier (font file) that is used later to patch fonts, to get the icons with a more relaxed license. That should be noted in the audit. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
4e318d3
to
3eab0c8
Compare
This does not pull in all icons of 6.5.1, but only of 'Region A' and 'Region B', see script `remix` and PR ryanoasis#1563. It keeps the codepoints constant for existing icons. Fixes: ryanoasis#1550 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Hi, I detected that the glyph I don't know if similar problems are found in other glyphs so I can't tell the severity of the "bug". |
Moved comment to #1596 |
We can the also incorporate |
Depending on the codepoints they assign to the icons (and they do have codepoint stability it seems), we can divide the Font Awesome icons into three (artifical) regions:
F000
-F2FF
(Region A)F300
-F8FF
(Region B)E000
-EFFF
(Region C)Region A is their dedicated allocation within Nerd Fonts codepoint space. At
F300
the next set (Font Logos) starts.For backward compatibility codepoints of existing icons in Region A have to be kept. The other codepoints (i.e. icons in Region B and C) fall to other icons sets' codepoint in Nerd Fonts space and have to be moved.
The question is how and where.
Possible scenario:
We could patch Region A to the codepoints of the current FA, filling the gaps with some of Region B.
The rest of Region B fits into
ED00
-EFFF
This PR does not introduce the icons from Region C.
This PR does not introduce
Regular
andSolid
(except where both variants were already inFont Awesome 4.3
).For licensing reasons we use the svgs and not the release font files. We loose their placement within the glyph bounding box this way, but I guess the scheme of placement we use now is not worse. For that soem actual patched fonts need to be inspected, esp the
Nerd Font Propo
variants.Fixes: #1550
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)