-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for Cloudflare #1646
Comments
For the reasons see Issue #1550 and PR #1563 Ref 1https://github.com/ryanoasis/nerd-fonts/blob/master/src/glyphs/font-awesome/README.md Ref 2https://github.com/ryanoasis/nerd-fonts/blob/master/src/glyphs/font-awesome/remix_mapping Ref 3The Edit: Add source link for ref 1 and 3 |
So in other words, it's not a good idea to add existing icons in different codepoints? |
That is all not easy ;-) Firstly Nerd Fonts is an icon pack aggregator, that means we take other collections and throw them into the target font. That as background. For the update of the FontAwesome icons we already take a complicated route. We keep codepoints of old versions stable; but they (FA) dropped some old icons completely. These vacant codepoints are reused for new FontAwesome icons that they put somewhere else, so there is already some codepoint movement. How the sets are distributed is documented here: There is just no space to have all icons that possibly exist. So we had to make a choice what to drop from the FontAwesome update, and affected where a lot brand icons. I understand that you really need this icon, but for us, that is a special rule that is disrupting all automatisms and has to be kept forever, even if you stop using cloudflare in half a year ;-) So, sorry, I guess it is not good to open this door. Maybe there is some other cloud-y icon that you could use instead? |
Nah, it's okay. I have found an alternative I can use. It's not a big deal. I was just curious since you pointed all this. Thanks for the clarification though, this is very informative. |
Yes. The reason was that - because there were so few 'free' codepoints - we used codepoints that are reserved for Chinese, Arab and other "exotic" languages. Who needs those glyphs, what can go wrong when we patch them over with useful icons. ... There were hardly any fonts with that glyphs anyhow - back then. But of course that raised complains from people who were missing the glyphs and really soon it became clear that we needed to change it. But still the preparation for the actual breaking change took literally years. |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
FA does have the icon https://fontawesome.com/icons/cloudflare, I wonder why isn't this in Nerd Fonts. Would love to see this being added, thanks :)
The text was updated successfully, but these errors were encountered: