-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patcher: explain the mono option better #165
Comments
@Taverius Sorry about that. We tried to explain better in some of the markdown files, for example: AnonymousPro Can I ask which closed issue you are referring to? 😊
Hmm it shouldn't be required but lately with the GUI builds of Vim there is an ambiguous width issue (glyphs cut in half). What was the issue? The fonts weren't working at all unless you used the mono versions?
I am all for this 😄. Did you have any specific place where more info would have helped? The readme? The patcher ( |
The latter, now working at all, GVim just wasn't seeing them - I'm running a very recent 8.0. So its a 'lately' thing? Hopefully upstream is aware and someone who understands the codebase can do something about it. As for explaining, the I'm just trying to save some time for anyone else who wants to patch Consolas/Input on non-(li|u)nix. Pointless edit: looked at the .md, and yup, it explains it, but that's probably not a file someone just wanting to patch a font will look at. Also, amusingly, ConEmu had no problem whatsoever with the double-width fonts :S |
In my opinion, the correct place for such explanations is the README.md. There are on the other hand things in the README that shouldn't be there cough images with wrong character codes cough. In fact, I would put the only the bare minimum in the |
@RuRo I agree readme would best.
Do you mean the "Seti-UI + Custom" set and "Font Awesome Extension" set? 😊
Sure I am always open to PRs 😄 Honestly I haven't made much progress lately on getting the next release (v1.1) out the door.. but I don't think there is much left to do. Possibly this weekend but I'd hate to promise 😊 |
- explains the mono option better (part of #165)
More info on the README would be great.
|
@luisdavim Yes you are right. This should now mostly be taken care of now with: b5e8271 and https://github.com/ryanoasis/nerd-fonts/wiki/FAQ-and-Troubleshooting#tldr |
thanks. and what about the fonts that have powerline in their names? They all seem to have the powerline glyphs anyway... |
Yeah good point. Those are originally from https://github.com/powerline/fonts Either we should upgrade the unpatched fonts to remove the 'for Powerline'/'powerline' or filter that out in the patcher. |
Considering this closed (with v1.1.0 release) |
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Nowhere does it say you need it for Mac/Win GVim to pick up the fonts :)
Had me scratching my head for an hour or so, looking at various topics on SO, before I happened on the a closed issue that mentions this.
The text was updated successfully, but these errors were encountered: