Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS powerline dividers in SymbolsOnly Regular #1695

Closed
Finii opened this issue Aug 28, 2024 · 2 comments
Closed

RHS powerline dividers in SymbolsOnly Regular #1695

Finii opened this issue Aug 28, 2024 · 2 comments

Comments

@Finii
Copy link
Collaborator

Finii commented Aug 28, 2024

This is a bug 😨

image

Originally posted by @Finii in #1694 (comment)

@Finii
Copy link
Collaborator Author

Finii commented Aug 28, 2024

It's ok in the 'normal' patched fonts, all 3 variants 😅

image

It happens only in the SymbolsNerdFont-Regular font (not the Mono), but seems to be with all right aligned glyphs?

image

@Finii Finii changed the title Inverse triangle position RHS powerline dividers in SymbolsOnly Regular Aug 28, 2024
Finii added a commit that referenced this issue Oct 30, 2024
[why]
The Powerline glyphs can have strange width if a non-mono font is
created. The width of the glyphs is then based on the symbol font which
is not always useful. Some get a very slim advance width.

[how]
Temporarely turn on '--mono' handling of the glyphs if a Powerline
codepoint is processed.

Fixes: #1695

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Nov 13, 2024
[why]
The right align check does produce wrong results if a proportional font
is generated.

[how]
Just skip the aspect ratio alignment re-check and leave the work to the
proportional font shifting that is done afterwards anyhow.

Fixes: #1695

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented Nov 13, 2024

Some right aligned glyphs in normal patched fonts are also affected

image
Here E0C7

@Finii Finii closed this as completed in f530e22 Nov 13, 2024
Finii added a commit that referenced this issue Nov 13, 2024
[why]
The right align check does produce wrong results if a proportional font
is generated.

[how]
Just skip the aspect ratio alignment re-check and leave the work to the
proportional font shifting that is done afterwards anyhow.

Fixes: #1695

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant