Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching Cascadia Code changes font height in Windows Terminal #519

Closed
BladeMF opened this issue Aug 27, 2020 · 7 comments
Closed

Patching Cascadia Code changes font height in Windows Terminal #519

BladeMF opened this issue Aug 27, 2020 · 7 comments

Comments

@BladeMF
Copy link

BladeMF commented Aug 27, 2020

🎯 Subject of the issue

When patching Cascadia Code 2008.25, whether the static ttf version or the static otf version, the font height changes significantly in Windows Terminal (both Ubuntu and Console). For TTF version the size change is visible in font settings in Notepad also. This was not true for the 2005 version of the font. The TTF version appears visibly larger than the OTF version which in turn is larger than the orignal font.

I appologise in advance if this is not a problem caused by Nerd Font's font patcher, I will take this up with the Microsoft guys if needed.

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    Cascadia Code 2008.25
  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
    Windows Terminal Version: 1.3.2382.0
  • Are you using OS X, Linux or Windows? And which specific version or distribution?
    Windows 2004 (OS Build 19041.450)

★ Optional

Please view the full size screenshots, otherwise the difference is not so obvious.

Original font

Annotation 2020-08-27 100846

v2005 TTF

2005 TTF

v2008 OTF

2008 OTF

2008 TTF

2008 TTF

@BladeMF
Copy link
Author

BladeMF commented Sep 28, 2020

Also, now I've noticed, the dot in the letter "i" in the OTF version is visiby closer to the stem.

@Ririshi
Copy link

Ririshi commented Feb 22, 2021

Cascadia Code has since attempted to fix the issue by supplying additional font height attributes in ttfautohint (which I am not familiar with, so I can sadly not be of assistance on that front), but it did not seem to help. My comment on the issue in their repo highlights very well what the issue is: microsoft/cascadia-code#371 (comment). I'm hoping we can find a fix for it, as I'd love to use oh-my-posh and powerlevel10k with Cascadia Code!

@trallnag
Copy link

trallnag commented Oct 1, 2021

Hey @Ririshi, I was just attempting to patch Cascadia, but I guess there's no point in it as this issue still persists. Can you recommend a nerd font does not have this issue?

@trallnag
Copy link

trallnag commented Oct 1, 2021

Here is another screenshot of the issue with the newest version of Cascadia Code:

Without patch:

image

After patching

image

@Finii Finii changed the title Patching Cascadia Code 2008.25 changes font height in Windows Terminal Patching Cascadia Code changes font height in Windows Terminal Feb 23, 2023
@Finii
Copy link
Collaborator

Finii commented Feb 23, 2023

The problem are the hints in the static fonts we use. They are already 'bad' in the Cascadia Code release files. This has nothing to do specifically with Nerd Fonts.

Compare yourself the Cascadia Code variable font (that obviously everyone compared to) to the parallel installed original Cascadia Code PL static fonts.

That it once worked and now doesnt is because the hints were manually created in the beginning, but later the static fonts became 2nd class citizens and were only autohinted. We reuse the existing not-so-good hints.

For interested see https://github.com/microsoft/cascadia-code/issues number 371 Improve ttfautohint hinting
(I don't want to create a backlink, so you have to search the issue yourselves.)

@Finii Finii closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2023
@Finii
Copy link
Collaborator

Finii commented Feb 23, 2023

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants