Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to include/patch trigrams (2630 through 2637) #589

Closed
4 tasks done
poetaman opened this issue Mar 10, 2021 · 2 comments · Fixed by #1125
Closed
4 tasks done

add option to include/patch trigrams (2630 through 2637) #589

poetaman opened this issue Mar 10, 2021 · 2 comments · Fixed by #1125

Comments

@poetaman
Copy link

poetaman commented Mar 10, 2021

🗹 Requirements

  • A brief but descriptive title of your issue
  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have read or scanned the FAQ
  • I have read or scanned the Wiki

🎯 Subject of the issue

Some powerline glyphs are not added by font-patcher. These are the same ones listed there: #100 (comment). The terminal emulator I use also slows down as a side effect, but that's not the main point. It will be good if font-patcher src fonts are updated to include these glyphs. Not all the terminal emulators support fallback fonts either, so can't really rely on that as a fix.

🔧 Your Setup

  • Which font are you using?
    -- OperatorMono (commercial font)
  • Which terminal emulator are you using?
    -- WezTerm
  • Are you using OS X?
    -- macOS
@ryanoasis ryanoasis changed the title Font patcher doesn't add some powerline glyphs (trigrams) add option to include/patch trigrams (2630 through 2637) Dec 14, 2021
@Finii
Copy link
Collaborator

Finii commented Feb 23, 2023

I believe at least 2630 should be added to the core set.

@Finii Finii added this to the v3.0.0 milestone Feb 23, 2023
Finii added a commit that referenced this issue Feb 23, 2023
[why]
The unicode 2630 (Trigraph Heaven) is often used in vim powerlines (at
least).

[how]
Draw nice 3 rectangles.
Insert 'pa1', always scaling also in non mono fonts. That needs a new
attribute: '!'.

The scaling is in fact an issue. Using 'pa' is the way of least
resistance.
Without the new attribute the glyph would look different in mono and
nonmono, which is not nice.

Fixes: #589

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Feb 23, 2023
2 tasks
Finii added a commit that referenced this issue Mar 2, 2023
[why]
The unicode 2630 (Trigraph Heaven) is often used in vim powerlines (at
least).

[how]
Draw nice 3 rectangles.
Insert 'pa1', always scaling also in non mono fonts. That needs a new
attribute: '!'.

The scaling is in fact an issue. Using 'pa' is the way of least
resistance.
Without the new attribute the glyph would look different in mono and
nonmono, which is not nice.

Fixes: #589

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii closed this as completed in ac3cb23 Mar 10, 2023
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
The unicode 2630 (Trigraph Heaven) is often used in vim powerlines (at
least).

[how]
Draw nice 3 rectangles.
Insert 'pa1', always scaling also in non mono fonts. That needs a new
attribute: '!'.

The scaling is in fact an issue. Using 'pa' is the way of least
resistance.
Without the new attribute the glyph would look different in mono and
nonmono, which is not nice.

Fixes: ryanoasis#589

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants