Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Not equal (!=)' ligature is broken for all JetBrains Mono Light/ExtraLight weights. #963

Closed
3 tasks done
alloc33 opened this issue Oct 12, 2022 · 10 comments · Fixed by #964
Closed
3 tasks done

'Not equal (!=)' ligature is broken for all JetBrains Mono Light/ExtraLight weights. #963

alloc33 opened this issue Oct 12, 2022 · 10 comments · Fixed by #964
Labels
confirmed externally blocked

Comments

@alloc33
Copy link

alloc33 commented Oct 12, 2022 •
edited
Loading

🗹 Requirements

  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:
'Not equal (!=)' ligature is broken on all JetBrains Mono ExtraLight/Light weights. Draws it incorrectly.

Expected behavior:
Expecting working 'not equal (!=)' ligature for Light/ExtraLight font weights.

Example symbols:
So far I recognized only one issue - '!=' draws incorrectly.

🔧 Your Setup

  • Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
    • Please give the full filename

Bug occurs in all Light/ExtraLight fonts:

  1. JetBrains Mono ExtraLight Nerd Font Complete Mono Windows Compatible.ttf

  2. JetBrains Mono ExtraLight Nerd Font Complete Mono.ttf

  3. JetBrains Mono ExtraLight Nerd Font Complete Windows Compatible.ttf

  4. JetBrains Mono ExtraLight Nerd Font Complete.ttf

    • Where did you get the file from (download link, self patched, source downloaded from link...)

Fonts are downloaded from:
https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/JetBrainsMono/Ligatures/ExtraLight/complete
(also tried to download from website - same)

  • Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?

All text editors are affected (JetBrains IDEs, Neovim, Neovide...)

  • Are you using OS X, Linux or Windows? And which specific version or distribution?

MacOS Monterey 12.6 (M1 Pro)

★ Screenshots (Optional)

Screen Shot 2022-10-12 at 10 09 51 AM

Screen Shot 2022-10-12 at 10 29 37 AM
@alloc33 alloc33 changed the title 'Not equal (!=)' ligature is broken for Light/ExtraLight weights. 'Not equal (!=)' ligature is broken for all JetBrains Mono Light/ExtraLight weights. Oct 12, 2022
@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022

image

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022 •
edited
Loading

Light also affected. ExtraLight Italic and Light Italic ok. All other JetBrainsMono ok.

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022 •
edited
Loading

The glyph itself looks ok in ff 🤔

Already broken upstream

image

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022 •
edited
Loading

See JetBrains/JetBrainsMono#494

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022

We could update to the not-yet-published JetBrains Mono 2.301, but I'd rather avoid that.

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022

Glyph is broken in ff:

image

We could transplant that one glyph.

Finii added a commit that referenced this issue Oct 12, 2022
@Finii
Fix JetBransMono != ligature
2a85212 
[why]
In JetBrainsMono v2.242 the exclam-equal ligature is broken.
It has been fixed in v3.000.

[how]
The JetBrains Mono v3 has not been released yet. So we just transplant
the one broken glyph from v3.000 into our v2.242.

[note]
JetBrains/JetBrainsMono#494

Fixes: #963

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Oct 12, 2022
Merged
2 tasks
Finii added a commit that referenced this issue Oct 12, 2022
@Finii
Fix JetBransMono != ligature
a72f996 
[why]
In JetBrainsMono v2.242 the exclam-equal ligature is broken.
It has been fixed in v3.000.

[how]
The JetBrains Mono v3 has not been released yet. So we just transplant
the one broken glyph from v3.000 into our v2.242.

[note]
JetBrains/JetBrainsMono#494

Fixes: #963

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022

@xbladesub Thanks for reporting. Maybe you can try the new (Extra)Light versions?

@Finii
Copy link
Collaborator

Finii commented Oct 12, 2022

Grr, just noticed I rebuilt the stuff with fontforge 2020 March Release instead of fontforge March 2022 Release.
Hope it went all well and no fontforge bugs crept up 🙄 Lost track of what is broken and what not.

@alloc33
Copy link
Author

alloc33 commented Oct 15, 2022 •
edited
Loading

@xbladesub Thanks for reporting. Maybe you can try the new (Extra)Light versions?

Now it's perfect. Thanks!

@Finii Finii mentioned this issue Jan 9, 2023
Closed
3 tasks
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed externally blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix JetBransMono != ligature ryanoasis/nerd-fonts
2 participants
@Finii @alloc33