Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UbuntuMono has no license file #979

Closed
moralground opened this issue Oct 23, 2022 · 4 comments · Fixed by #981
Closed

UbuntuMono has no license file #979

moralground opened this issue Oct 23, 2022 · 4 comments · Fixed by #981

Comments

@moralground
Copy link

The UbuntuMono.zip file doesn't include any kind of license like most of the others. Could this be fixed?

@Finii
Copy link
Collaborator

Finii commented Oct 24, 2022

Thanks for reporting this. Of course.
Put it on the v2.3.0 list #962

I will have to investigate why it is missing in some and not in others. Probably because it is LICENCE.txt for Ubuntu and not just LICENCE

@Finii
Copy link
Collaborator

Finii commented Oct 24, 2022

... LICENSE vs LICENCE 🙄

@Finii
Copy link
Collaborator

Finii commented Oct 24, 2022

Affected:
Archive: ./FantasqueSansMono.zip
Archive: ./Ubuntu.zip
Archive: ./UbuntuMono.zip
Archive: ./Tinos.zip
Archive: ./Inconsolata.zip
Archive: ./ProggyClean.zip
Archive: ./NerdFontsSymbolsOnly.zip
Archive: ./Monoid.zip
Archive: ./HeavyData.zip
Archive: ./InconsolataGo.zip
Archive: ./Lekton.zip
Archive: ./BitstreamVeraSansMono.zip
Archive: ./SpaceMono.zip
Archive: ./JetBrainsMono.zip
Archive: ./AurulentSansMono.zip
Archive: ./ShareTechMono.zip

Finii added a commit that referenced this issue Oct 24, 2022
[why]
We have 'license' is the archives, but the 'licence' files are missing.
We allow all-caps and all-lowercase, but not camelcase 'License'.
Sometimes we have OFL.txt which is missing.

[how]
Enable both spellings and also camelcase.
Enable OTF text files.

Also fix misunderstanding of regex vs glob ([] vs {}), where the glob
needs a comma and the regex does not.

Add missing LICENSE files for 2 fonts.

Fixes: #979

Reported-by: Jeremy Thorn <moralground>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Oct 24, 2022
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
[why]
We have 'license' is the archives, but the 'licence' files are missing.
We allow all-caps and all-lowercase, but not camelcase 'License'.
Sometimes we have OFL.txt which is missing.

[how]
Enable both spellings and also camelcase.
Enable OTF text files.

Also fix misunderstanding of regex vs glob ([] vs {}), where the glob
needs a comma and the regex does not.

Add missing LICENSE files for 2 fonts.

Fixes: ryanoasis#979

Reported-by: Jeremy Thorn <moralground>
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants