Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need --cask params anymore #1079

Merged
merged 1 commit into from
Jan 26, 2023
Merged

No need --cask params anymore #1079

merged 1 commit into from
Jan 26, 2023

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 26, 2023

Description

No need --cask param to install cask via brew.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

brew tap homebrew/cask-fonts
brew install font-hack-nerd-font

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

Thanks for the PR!

According to https://github.com/Homebrew/homebrew-cask-fonts#lets-try-it you are right.
Their own documentation does not mention --cask for the font install:

image

On the other hand, if you are like me, and try this on your own machine, there is a difference:

$ brew tap homebrew/cask-fonts
Running `brew update --auto-update`...
==> Auto-updated Homebrew!
==> Updated Homebrew from 9c88c39ba to 3.6.20 (7e77b89e2).
No changes to formulae.


The 3.6.0 release notes are available on the Homebrew Blog:
  https://brew.sh/blog/3.6.0
The 3.6.20 changelog can be found at:
  https://github.com/Homebrew/brew/releases/tag/3.6.20
==> Tapping homebrew/cask-fonts
Cloning into '/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-cask-fonts'...
remote: Enumerating objects: 66096, done.
remote: Counting objects: 100% (161/161), done.
remote: Compressing objects: 100% (64/64), done.
remote: Total 66096 (delta 114), reused 137 (delta 97), pack-reused 65935
Receiving objects: 100% (66096/66096), 13.01 MiB | 8.64 MiB/s, done.
Resolving deltas: 100% (48972/48972), done.
Tapped 2007 casks (2,042 files, 16.2MB).
$

So far, so good. And now the actual install:

$ brew install font-inconsolata
Warning: No available formula with the name "font-inconsolata". Did you mean fonts-encodings?
==> Searching for similarly named formulae...
==> Formulae
fonts-encodings

To install fonts-encodings, run:
  brew install fonts-encodings
$

"WAT?!! What does that mean?!?!". Lets add the --cask, as suggested in the Nerd Font readmes:

$ brew install --cask font-inconsolata
Error: Invalid `--cask` usage: Casks do not work on Linux
$

AH!! Right.
That error message makes much more sense.

Is it really better to not say --cask but have people come here and complain it fails with unreadable error messages?

@Goooler
Copy link
Contributor Author

Goooler commented Jan 26, 2023

Seems no such a error occurs on my device, do you use brew on Linux?

Last login: Thu Jan 26 19:28:23 on ttys000
 snebula@MBP  ~  brew tap homebrew/cask-fonts
Running `brew update --auto-update`...
==> Auto-updated Homebrew!
Updated 5 taps (mdogan/zulu, jandedobbeleer/oh-my-posh, homebrew/core, homebrew/cask and homebrew/services).
==> New Formulae
ancient                  m1ddc                    mdless                   zsh-autopair
==> New Casks
serene

You have 5 outdated formulae installed.
You can upgrade them with brew upgrade
or list them with brew outdated.

==> Tapping homebrew/cask-fonts
Cloning into '/opt/homebrew/Library/Taps/homebrew/homebrew-cask-fonts'...
remote: Enumerating objects: 66096, done.
remote: Counting objects: 100% (161/161), done.
remote: Compressing objects: 100% (64/64), done.
remote: Total 66096 (delta 114), reused 137 (delta 97), pack-reused 65935
Receiving objects: 100% (66096/66096), 13.01 MiB | 884.00 KiB/s, done.
Resolving deltas: 100% (48972/48972), done.
Tapped 2007 casks (2,042 files, 16.1MB).
 snebula@MBP  ~  brew install font-hack-nerd-font
==> Downloading https://github.com/ryanoasis/nerd-fonts/releases/download/v2.3.3/Hack.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/27
##############################################                            64.1%curl: (92) HTTP/2 stream 1 was not closed cleanly before end of the underlying stream

Error: Download failed on Cask 'font-hack-nerd-font' with message: Download failed: https://github.com/ryanoasis/nerd-fonts/releases/download/v2.3.3/Hack.zip
 ✘ snebula@MBP  ~  brew install font-hack-nerd-font
==> Downloading https://github.com/ryanoasis/nerd-fonts/releases/download/v2.3.3/Hack.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/27
######################################################################## 100.0%
==> Installing Cask font-hack-nerd-font
==> Moving Font 'Hack Regular Nerd Font Complete.ttf' to '/Users/snebula/Library/Fonts/Hack Regular
==> Moving Font 'Hack Bold Italic Nerd Font Complete.ttf' to '/Users/snebula/Library/Fonts/Hack Bold
==> Moving Font 'Hack Bold Nerd Font Complete Mono.ttf' to '/Users/snebula/Library/Fonts/Hack Bold N
==> Moving Font 'Hack Bold Nerd Font Complete.ttf' to '/Users/snebula/Library/Fonts/Hack Bold Nerd F
==> Moving Font 'Hack Italic Nerd Font Complete Mono.ttf' to '/Users/snebula/Library/Fonts/Hack Ital
==> Moving Font 'Hack Italic Nerd Font Complete.ttf' to '/Users/snebula/Library/Fonts/Hack Italic Ne
==> Moving Font 'Hack Regular Nerd Font Complete Mono.ttf' to '/Users/snebula/Library/Fonts/Hack Reg
==> Moving Font 'Hack Bold Italic Nerd Font Complete Mono.ttf' to '/Users/snebula/Library/Fonts/Hack
🍺  font-hack-nerd-font was successfully installed!
 snebula@MBP  ~  brew install fonts-encodings
==> Fetching fonts-encodings
==> Downloading https://ghcr.io/v2/homebrew/core/fonts-encodings/manifests/1.0.6
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/fonts-encodings/blobs/sha256:863542f9892912c4f98cf5
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:863542f9892912c
######################################################################## 100.0%
==> Pouring fonts-encodings--1.0.6.arm64_ventura.bottle.tar.gz
🍺  /opt/homebrew/Cellar/fonts-encodings/1.0.6: 56 files, 653KB
==> Running `brew cleanup fonts-encodings`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
 snebula@MBP  ~  brew install font-inconsolata
==> Downloading https://github.com/google/fonts/raw/main/ofl/inconsolata/Inconsolata%5Bwdth%2Cwght%5
==> Downloading from https://raw.githubusercontent.com/google/fonts/main/ofl/inconsolata/Inconsolata
######################################################################## 100.0%
Warning: No checksum defined for cask 'font-inconsolata', skipping verification.
==> Installing Cask font-inconsolata
==> Moving Font 'Inconsolata[wdth,wght].ttf' to '/Users/snebula/Library/Fonts/Inconsolata[wdth,wght]
🍺  font-inconsolata was successfully installed!
 snebula@MBP  ~ 

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

Seems no such a error occurs on my device, do you use brew on Linux?

Shure ;-) That's the point. You can leave the --cask off, until you cant ;-)

@Goooler
Copy link
Contributor Author

Goooler commented Jan 26, 2023

I'm trying to repro, this might be a bug of brew.

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

You think the casks should work on Linux?

@Goooler
Copy link
Contributor Author

Goooler commented Jan 26, 2023

We should not use --cask on Linux, see Homebrew/discussions#3999.

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

Yes. So they do not work for me.
But if I follow instructions (without --cask) I get no meaningful error message.
With --cask I at least know the reason.

@Goooler
Copy link
Contributor Author

Goooler commented Jan 26, 2023

Filed it at Homebrew/homebrew-cask-fonts#7040.

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

Rebase on master, force push

@Finii
Copy link
Collaborator

Finii commented Jan 26, 2023

As 'they' themselves suggest installing without --cask we should follow that.

Thanks for the PR!

@all-contributors Do you want to add @Goooler for doc?

@allcontributors
Copy link
Contributor

@Finii

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Goooler! 🎉

@Finii Finii merged commit 5f03997 into ryanoasis:master Jan 26, 2023
@Goooler Goooler deleted the cask branch January 26, 2023 23:49
scottames pushed a commit to scottames/dots that referenced this pull request May 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ryanoasis/nerd-fonts](https://github.com/ryanoasis/nerd-fonts) |
major | `v2.3.3` -> `v3.0.0` |

---

### Release Notes

<details>
<summary>ryanoasis/nerd-fonts</summary>

###
[`v3.0.0`](https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.0)

[Compare
Source](https://github.com/ryanoasis/nerd-fonts/compare/v2.3.3...v3.0.0)

***Update: Preparation already for a bugfix release, see known bugs
[here](https://github.com/ryanoasis/nerd-fonts/milestone/26)***

This major release introduces some breaking changes:

##### Breaking 1: Naming

This release fixes some long standing issues that are due to the naming
of the fonts: There is a completely new naming scheme. This might be
inconvientient for existing setups, sorry.

- Some fonts will have `Nerd Font` in the name while other have it
abbreviated as `NF`. This is needed because some names just were too
long. (Same for `Nerd Font Mono` and `NFM`.)
- There are no `Windows Compatible` fonts anymore. All fonts work on all
platforms.
- The `Complete` from the font names (and the repo directories) has been
dropped (Complete is the new normal).
- The name parts will be ordered as expected with style and weight last
(`Somefont Bold Nerd Font` -> `Somefont Nerd Font Bold`).
-   The filename will have no blanks anymore.

##### Breaking 2: Material Design Icons Codepoints

The old Material Design Icon codepoints are finally dropped. Due to an
historic mistace we placed them in between some asiatic glyphs, breaking
that script.
Since v2.3.0 the (updated and expanded) Material Design Icons have new
codepoints in the 5 digit region.

-   Dropped codepoints `F500`... and class names `nf-mdi-*`
- New codepoints `F0001`... and class names `nf-md-*` (already since
`v2.3.0`)
- The whole discussions are here:
[ryanoasis/nerd-fonts#365
- A translation table is available here:
[ryanoasis/nerd-fonts#1059 (comment)
- There are tools out there that probably can update your configuration.
- Relevant thread:
[#&#8203;1190](https://github.com/ryanoasis/nerd-fonts/issues/1190)

Otherwise this is a 'Update release', so now the good stuff:

##### Updates

-   Update `Agave` to v37
-   Update `Arimo` to 1.33
-   Update `DaddyTimeMono` to 1.2.3
-   Update `Fira Mono` to 3.206
-   Update `Go Mono` to 2.010
-   Update `Hermit` to 2.0
-   Update `IBM Plex` to 2.3
-   Update `Iosevka` to 22.1.0
-   Update `Literation` to 2.1.5
-   Update `Lilex` to 2.000
-   Update `mononoki` to 1.6
-   Update `MPlus` to ... current
-   Update `Overpass` to 3.0.5
-   Update `Roboto Mono` to 3.0
-   Update `Source Code Pro` to 2.038
-   Update `Terminus` to 4.49.2
-   Update `Victor Mono` to 1.5.4
-   Update the Octicons set to 18.3.0

##### Features

-   New font `ComicShannsMono`
-   New variant in release `Nerd Font Propo` for GUI usecases
-   Patch in heavy angle brackets
-   Patch in boxdrawing glyphs (if the font has no complete set)
-   Repair Panose info if source font has broken data
-   Reform PowerlineExtra sizing
-   Autocreate a `FontPatcher.zip` from `HEAD`
-   Create a json database with css names
-   Disentangle `Iosevka` into two packets (one for `Iosevka Term`)
- Add option to manipulate `xAvgCharWidth` (needed rarely by
self-patchers)
-   Add option to allow italic-less fonts with oblique
-   Add `--debug` and `--dry` to `font-patcher`
-   Add logging into file to `font-patcher`
- Add `NERDFONTS` environment variable to transport options through
`gotta-patch-em`

##### Improvements

- Fix `Caskaydia Code` height different to `Cascadia Code` (hinting
problem) (font is now `ttf` instead of `otf`!)

##### Fixes

-   Fix baseline to basline distance (line gap) for some fonts
-   Fix weather icons cloud scaling
-   Fix UniqueID of the fonts
- Fix `Bitstream Vera` name: Is now `Bitstrom Wera` due to licensing
issue
-   No fix, but: Drop support for Python 2

#### New Contributors

- [@&#8203;Goooler](https://github.com/Goooler) made their first
contribution in
[ryanoasis/nerd-fonts#1079
- [@&#8203;MicaelJarniac](https://github.com/MicaelJarniac) made their
first contribution in
[ryanoasis/nerd-fonts#1100
- [@&#8203;teatimeguest](https://github.com/teatimeguest) made their
first contribution in
[ryanoasis/nerd-fonts#1119
- [@&#8203;b-](https://github.com/b-) made their first contribution in
[ryanoasis/nerd-fonts#1044
- [@&#8203;Weltolk](https://github.com/Weltolk) made their first
contribution in
[ryanoasis/nerd-fonts#1163
- [@&#8203;sullrich84](https://github.com/sullrich84) made their first
contribution in
[ryanoasis/nerd-fonts#1166

**Full Changelog**:
ryanoasis/nerd-fonts@v2.3.3...v3.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/scottames/dots).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43MS4wIiwidXBkYXRlZEluVmVyIjoiMzUuNzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants