Add Martian Mono #1092
Add Martian Mono #1092
Conversation
|
This looks good, thanks for the PR! Missing is just the change in What I ask myself, is it really necessary to include all width and weights? Given the source is a VF people might 'miss' any number of intermediate values on all axis 😬 And the package size is considerable. Are these all relevant for coding? What is the goal of patching them all? |
|
Hmm, noted that they put the very abbreviated names everywhere, ID16/17 could benefit from expanded names 🤔
How should non-font-geeks decode these? See also http://glyphsapp.com/learn/naming Maybe raise an issue over there? What do you think? |
Sure, let's get a subset! Any suggestions from your experience? I personally use only |
|
Regarding to the naming system. This naming convention has its own benefits. That was well-considred decision, made with Glyphs app “Naming” tutorial in mind. |
|
Any plans to merge this one? |
|
Well, it does not have a 3.0.0 milestone tag. I would rather push out 3.0.0 asap and add other stuff only afterwards. So I guess someone needs to sit down and think, and I personally would rather spend the time on getting 3.0.0 out, finally. |
Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
SemiWide and Narrow might be nice in some contexts, but that is not really the audience of Nerd Fonts I guess. Lets start with few and we can always add more if there is really a demand. Simplify the paths; the old style stems from the time when we patched all variants per source font. Nowerdays the fonts are few (3 per source) and will almost always be installed together anyhow. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] With Martian Mono we have a font that uses aggressive abbreviation for the weights and styles (two letters mostly) in all name fields. That is very hard to parse. [how] Adding rules that detect these very short abbreviations might trigger in a lot wrong places. As this is the only font that uses that we do not want to risk that. Instead we rewrite the filenames of the source font (Martian Mono) such that it contains all the necessary information and add a new flag to the patcher that allows it to use the filename as naming source. Yes, as in days long past ;-) Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] With Martian Mono we have a font that uses aggressive abbreviation for the weights and styles (two letters mostly) in all name fields. That is very hard to parse. [how] We rewrite the filenames such that it contains all the necessary information and use the new patcher flag use the filename as naming source. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
Rebase on master, force push. Also added some more commits, for example to improve the naming and dropped quite some fontfaces. |
|
@allcontributors please add @skryukov for code |
|
I've put up a pull request to add @skryukov! 🎉 |
|
@allcontributors please add @skryukov for code |
Description
This PR adds Martian Mono font.
Requirements / Checklist
Any background context you can provide?
As far as I understand, contributing guide is a bit outdated, I'm not quite sure that I made all the changes required:
bin/scripts/lib/fonts.jsonWhat are the relevant tickets (if any)?
#937