Reintroduce Octicons file-symlink-directory #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
feature/keep-symlink-dir
branch
from
c920ff3 to
2fb1df9
Compare
[why] Some people, for example the `lsd` project, need an icon with a symlink directory. That has been dropped by Octicons. Our repacking put some unrelated bookmark icon on that codepoint; but even an empty glyph would be not ideal. [how] Design a file-symlink-directory from file-symlink-file and file-directory. In this way it fits nicely into the current design of Octicons. Sneak that into the unpacked Octicons archive. Adapt mapping manually to keep as much as possible constant. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Just run ./generate. Compare commit 7764e05 Create new octicons.ttf (update to v18.3.0) (2/2) Fixes: 1213 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/keep-symlink-dir
branch
from
2fb1df9 to
9f54f24
Compare
6 tasks
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
…-dir [skip ci] Reintroduce Octicons file-symlink-directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit re-introduces the
oct-file_symlink_directotyicon we dropped withv3.0.0.It was dropped, because we updated Octicons and THEY dropped it.
As that is used for example by
lsdand is (was) the only icon that depicts a symlink directory:directoryandsymlink-fileicons.Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
primer/octicons#945
https://github.com/lsd-rs/lsd/blob/2fe3fcdd3564836962eab8ba6b1444996fe24e1e/src/theme/icon.rs#L85
What are the relevant tickets (if any)?
Fixes: #1213
Screenshots (if appropriate or helpful)