Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe patcher family-name generation in readme #1362

Merged
merged 3 commits into from
Sep 30, 2023

Conversation

frantisekhanzlikbl
Copy link
Contributor

@frantisekhanzlikbl frantisekhanzlikbl commented Sep 29, 2023

Description

updated the project's readme to mention that the font patcher CamelCases and removing whitespace from the resulting font's family names.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

the change contains GitHub's alert syntax, which might not render in the preview, but should render in the actual readme. (ref: https://github.com/orgs/community/discussions/16925#discussioncomment-6879962)

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@Finii
Copy link
Collaborator

Finii commented Sep 30, 2023

Thanks for the PR.

I'm not sure with the term "Family"... altough technically correct, maybe we should say just 'name' instead?
For the not so expertly users?
Or at least "Family name"?

@Finii
Copy link
Collaborator

Finii commented Sep 30, 2023

@allcontributors pleas add @frantisekhanzlikbl for doc

@allcontributors
Copy link
Contributor

@Finii

I've put up a pull request to add @frantisekhanzlikbl! 🎉

@frantisekhanzlikbl
Copy link
Contributor Author

Thanks for the PR.

I'm not sure with the term "Family"... altough technically correct, maybe we should say just 'name' instead? For the not so expertly users? Or at least "Family name"?

That makes sense. I'd lean towards mentioning both, since at least for web devs, the term family is more widely used, I believe. What about the current patch, does that look OK?

@Finii
Copy link
Collaborator

Finii commented Sep 30, 2023

What about the current patch, does that look OK?

Perfect. Thanks again.

@Finii Finii merged commit 871dd80 into ryanoasis:master Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants