Add Githubnext Monaspace #1405

julien-blanchon · 2023-11-10T09:38:26Z

Description

Added and patched Github Monaspace

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

add Github Monaspace unpatched font
add license & readme
patch the font
update readme
provide an update script for the font

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Closes #1403

Screenshots (if appropriate or helpful)

julien-blanchon · 2023-11-10T09:43:55Z

To patch:
find src/unpatched-fonts/Monaspace*/ -name "*.otf" -exec fontforge --script ./font-patcher {} --complete --debug 2 \;

julien-blanchon · 2023-11-10T10:02:55Z

I hope v3.0.3 is coming soon with it 🤗

Finii · 2023-11-10T10:09:26Z

Thanks for the PR! (for my own Issue ;-)

From what I gleamed you did not add a license file.
I can add that, and I would like to change the directory structure as well.
Nothing needs to be done from your side.

But what I would like to do is reducing the number of weights. Do you really think all the weights are useful?

Finii · 2023-11-10T10:11:12Z

I hope v3.0.3 is coming soon with it 🤗

I am about to finalise 3.1.0, writing it up in #1404, but slow going as I have to work 'for my meals' in parallel ;)

julien-blanchon · 2023-11-10T10:12:25Z

Thanks !

I think the License+Readme are on subdirectories for each font.
Sure feel free to fix anything you like <3
Yes I don't think we need that much font, we can maybe prune some file to reduce the size

julien-blanchon · 2023-11-10T10:13:45Z

I am about to finalise 3.1.0, writing it up in #1404, but slow going as I have to work 'for my meals' in parallel ;)

Haha no worries, I think many people are alredy waiting for Nerd Font to add Monaspace to use it in vs-code

Finii · 2023-11-10T10:18:14Z

use it in vs-code

Unfortunately there is a ~~bug~~ peculiarity with Visual Studio 2022 that breaks on a lot fonts and that might need a fix beforehand? See #1242
Well, that is not VS-Code, but still related maybe.

Finii

Not ready, but easy to fix.

Except that we need to come up with a name substitute.

bin/scripts/lib/fonts.json

Finii · 2023-11-10T13:03:13Z

bin/scripts/lib/fonts.json

+      "patchedName": "MonaspaceArgon",
+      "folderName": "MonaspaceArgon",
+      "imagePreviewFont": "Monaspace Argon Nerd Font",
+      "linkPreviewFont": "monaspace-argon",


This is just not true?!
Is a PR ongoing?

I'm not sure what to do, I let you edit the PR if needed

That's the details part of a link to https://programmingfonts.org, but I do not see Monaspace there at all.

bin/scripts/lib/fonts.json

readme.md

Co-authored-by: Fini <ulf.fini.jastrow@desy.de>

SemiWide and ExtraWide might be nice in some contexts, but that is not really the audience of Nerd Fonts I guess. Lets start with few and we can always add more if there is really a demand. Simplify the paths; the old style stems from the time when we patched all variants per source font. Nowerdays the fonts are few (3 per source) and will almost always be installed together anyhow. Shorten the naming a bit for, for example ERROR: ====-< Family (ID 1) too long (37 > 31): MonaspaceXenon Nerd Font Propo Medium Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] Monaspace has an RFN that individually protects 'Monaspace' and all the face names of noble gases 'Xenon' etc. Both must not be used on patched fonts. [how] Just add the rule(s). The concrete naming is not decided yet. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-11-10T19:46:52Z

Force push because I had one name wrong 😬

Finii · 2023-11-10T19:49:42Z

Fixing shellcheck issues (forgot to run that locally), force push imminent...

[why] Shellcheck complains that quotes are missing. We know that there will not be any problem ever as the elements are hard coded, but fix to be warning free. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-11-10T19:59:44Z

To patch: find src/unpatched-fonts/Monaspace*/ -name "*.otf" -exec fontforge --script ./font-patcher {} --complete --debug 2 \;

Well, I usually run

$ NERDFONTS="--debug 2" bin/scripts/gotta-patch-em-all-font-patcher\!.sh -v /Monaspace

or without debug-info and with parallel processing to be finished faster add -j:

$ bin/scripts/gotta-patch-em-all-font-patcher\!.sh -jv /Monaspace

To see just all the re-naming and do not really patch, add --dry to the NERDFONTS envvar.

Edit: Additional info:

The difference is that patch em all patches all 3 variants (Nerd Font, Nerd Font Mono, and Nerd Font Propo) and respects the contents of config.cfg (and allows to run multiple patch processes concurrently - nice if you have more cores).

bradwilson · 2023-11-10T21:10:44Z

FYI, I pulled this PR, built the fonts and installed the Mono variant of them. They have the same problem described in #1242 where Visual Studio is unable to display the font and falls back to Courier New.

(No issues with the font in VS Code or Windows Terminal, just in Visual Studio 2022)

Basically just confirming #1405 (comment) is true.

Finii · 2023-11-10T22:00:17Z

They have the same problem described in #1242 where Visual Studio is unable to display the font and falls back to Courier New.

Working on this now with 1st priority (i.e. this night). Stole the gaming laptop from one of my kids to have a real Windows machine next to me 😬 Installing Visual Studio 2022 Community ...

Finii · 2023-11-11T03:35:53Z

Hope #1242 is fixed with #1406, any volunteers to test welcome (I need sleep)

Finii · 2023-11-11T23:33:38Z

@allcontributors please add @julien-blanchon for code

allcontributors · 2023-11-11T23:33:47Z

@Finii

I've put up a pull request to add @julien-blanchon! 🎉

julien-blanchon · 2023-11-12T00:28:12Z

Wow it's already ready, thanks you very much

felipesere · 2023-11-12T14:10:01Z

With #1406 merged, can Monaspace be merged now too? 😻

Finii · 2023-11-16T05:36:16Z

We are still waiting for upstream (i.e. @idan) on a naming decision (see [1]).
If we release now the patched font will (have to) be called MoniSpace Nerd Font (or similar).
The release can/will be triggered once we have a decision.

(Well, and after the other still open PR is/are merged, I continue adding stuff meanwhile)

[1] #1403 (comment)

Finii · 2023-11-16T06:45:52Z

Maybe some of you want to try the patched font out, and report bugs. So we can fix the issues before release?

MonispaceNeonNerdFont.tar.xz.gz

Thank you!

P.S.: The archive is tar.xz for good compression and gz because Github does not support xz, sorry for the incenvenience

bradwilson · 2023-11-17T21:29:38Z

@Finii Can confirm that this version works as expected in VS 2022! 🎉

After the working draft name Monispace the final patched font name will be Monaspice. * It keeps the characteristic `Mona` in the beginning * It changes just one character * The replacement is still a real word * The replacements sounds very similar Also other very good names have been suggested, thank you all for the input! Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

bradwilson · 2023-11-19T21:55:35Z

I see the preview for the new font on the NerdFonts.com sit, but the download does not work (and I could not find the patched fonts in the repo yet). Am I too early? Is everything still being deployed? 😄

Finii · 2023-11-19T23:41:46Z

@bradwilson

I see the preview for the new font on the NerdFonts.com sit, but the download does not work (and I could not find the patched fonts in the repo yet). Am I too early? Is everything still being deployed? 😄

See

Font download file not found (Release v3.1.0 missing) #1411

…aspace Add Githubnext Monaspace

Add Gihtub Monaspace

4ed7ec9

Remove .DS_Store

2ea1894

Finii changed the title ~~Add Gihtub Monaspace~~ Add Githubnext Monaspace Nov 10, 2023

Finii added this to the v3.1.0 milestone Nov 10, 2023

redactedscribe mentioned this pull request Nov 10, 2023

Add font Monaspace #1403

Closed

Finii reviewed Nov 10, 2023

View reviewed changes

julien-blanchon and others added 6 commits November 10, 2023 14:16

Update fonts.json

ed9d539

Co-authored-by: Fini <ulf.fini.jastrow@desy.de>

Update readme.md

2f312fa

Co-authored-by: Fini <ulf.fini.jastrow@desy.de>

Moving Monaspace in fonts.json

b9bef82

Update description using keyword provide by Github

5057ded

Finii force-pushed the add-github-monaspace branch from 456cdb5 to 447fbc2 Compare November 10, 2023 19:46

Monaspace: Fix updater script

8563b0c

[why] Shellcheck complains that quotes are missing. We know that there will not be any problem ever as the elements are hard coded, but fix to be warning free. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii added the ❲Aa❳ new font label Nov 10, 2023

Finii added externally blocked Ready ⛱ Ready to merge but waiting to be merged near a release labels Nov 11, 2023

allcontributors bot mentioned this pull request Nov 11, 2023

docs: add julien-blanchon as a contributor for code #1410

Merged

Finii mentioned this pull request Nov 16, 2023

These fonts are unusable in modern IDEs and editors. githubnext/monaspace#111

Closed

Finii removed the externally blocked label Nov 19, 2023

Finii force-pushed the add-github-monaspace branch from b9e0864 to c56530c Compare November 19, 2023 21:07

Finii merged commit 5d999cd into ryanoasis:master Nov 19, 2023
1 of 2 checks passed

rollingmoai mentioned this pull request Nov 20, 2023

Add Nerd Fonts githubnext/monaspace#24

Open

redactedscribe mentioned this pull request Nov 20, 2023

Add Monaspace Nerd Font matthewjberger/scoop-nerd-fonts#260

Closed

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023

Merge pull request ryanoasis#1405 from julien-blanchon/add-github-mon…

82934a2

…aspace Add Githubnext Monaspace

RaccoonBoryvitter mentioned this pull request Feb 13, 2024

Nerd Fonts - Please - When? 🙏 githubnext/monaspace#188

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Githubnext Monaspace #1405

Add Githubnext Monaspace #1405

julien-blanchon commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii left a comment

Finii Nov 10, 2023 •

edited

Loading

julien-blanchon Nov 10, 2023 •

edited

Loading

Finii Nov 10, 2023

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023 •

edited

Loading

bradwilson commented Nov 10, 2023 •

edited

Loading

Finii commented Nov 10, 2023

Finii commented Nov 11, 2023

Finii commented Nov 11, 2023

allcontributors bot commented Nov 11, 2023

julien-blanchon commented Nov 12, 2023

felipesere commented Nov 12, 2023

Finii commented Nov 16, 2023

Finii commented Nov 16, 2023

bradwilson commented Nov 17, 2023

bradwilson commented Nov 19, 2023

Finii commented Nov 19, 2023

Add Githubnext Monaspace #1405

Add Githubnext Monaspace #1405

Conversation

julien-blanchon commented Nov 10, 2023

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

julien-blanchon commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

julien-blanchon commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii left a comment

Choose a reason for hiding this comment

Finii Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

julien-blanchon Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

Finii Nov 10, 2023

Choose a reason for hiding this comment

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023

Finii commented Nov 10, 2023 • edited Loading

bradwilson commented Nov 10, 2023 • edited Loading

Finii commented Nov 10, 2023

Finii commented Nov 11, 2023

Finii commented Nov 11, 2023

allcontributors bot commented Nov 11, 2023

julien-blanchon commented Nov 12, 2023

felipesere commented Nov 12, 2023

Finii commented Nov 16, 2023

Finii commented Nov 16, 2023

bradwilson commented Nov 17, 2023

bradwilson commented Nov 19, 2023

Finii commented Nov 19, 2023

Finii Nov 10, 2023 •

edited

Loading

julien-blanchon Nov 10, 2023 •

edited

Loading

Finii commented Nov 10, 2023 •

edited

Loading

bradwilson commented Nov 10, 2023 •

edited

Loading