Update nerd-fonts-generated.css #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The speak property is not widely supported and is currently not a standard property. If you're using it to prevent screen readers from reading certain elements, a more standard approach is to use the aria-hidden="true" attribute in your HTML. This will hide the span with the class nf from screen readers. This is a more widely supported and standard way of controlling how screen readers interact with your elements.
This reverts commit b1d437b. Because that changed a generated file. The generator is changed instead with the changes added here.
|
Thanks for the PR! I'm no web programmer and such details are beyond me, so we must rely on expert like you :-) |
|
oh, no problem what so ever, in fact github CoPilot caught it, I was just
being a good steward of information flow
…On Tue, Nov 14, 2023 at 4:43 AM Fini ***@***.***> wrote:
Thanks for the PR!
I'm no web programmer and such details are beyond me, so we must rely on
expert like you :-)
—
Reply to this email directly, view it on GitHub
<#1416 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWSIABIEMTUJKRWAM7OOGGTYENROZAVCNFSM6AAAAAA7KXD7WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGEZTKMRTGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Update nerd-fonts-generated.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The css 'speak' property is not widely supported and is currently not a standard property. If you're using it to prevent screen readers from reading certain elements, a more standard approach is to use the aria-hidden="true" attribute in your HTML.
This will hide the span with the class nf from screen readers. This is a more widely supported and standard way of controlling how screen readers interact with your elements.
it's really not much to get excited about, I just noticed it, and wanted to bring it up to your attention.
the line has been wrapped in a comment.
/* speak: none; */