Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown by forcing html #148

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Conversation

aloisdg
Copy link
Contributor

@aloisdg aloisdg commented Apr 1, 2017

Description

I found a markup problem in the readme.
I fixed the markdown by adding the html directly.

Requirements / Checklist

What does this Pull Request (PR) do?

Fix markup

Screenshots (if appropriate or helpful)

see the diff :)

@ryanoasis
Copy link
Owner

@aloisdg Woah I haven't noticed that! Thanks for the fix! 😄

This had rendered correctly before, seems like a recent GitHub change has caused this. Perhaps: https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown

@ryanoasis ryanoasis added this to the v1.1.0 milestone Apr 1, 2017
@ryanoasis ryanoasis merged commit a8f5813 into ryanoasis:master Apr 1, 2017
@aloisdg
Copy link
Contributor Author

aloisdg commented Apr 1, 2017

@ryanoasis Yes maybe. I didnt check the whold document by the way.

@aloisdg aloisdg deleted the patch-1 branch April 1, 2017 12:27
@ryanoasis
Copy link
Owner

@aloisdg Yep sure that makes sense. Actually I see another issue down below I will fix. I think there will be quite a few repos on GitHub with some fixes needed 😆

@aloisdg
Copy link
Contributor Author

aloisdg commented Apr 1, 2017

A bot could fix that. :)

@ryanoasis
Copy link
Owner

Hah you are probably right 😄

Thanks again for the PR, inspired me to make some improvements to the readme and wiki 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants