Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iosevka Term Slab #803

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Add Iosevka Term Slab #803

merged 3 commits into from
Nov 13, 2023

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Mar 4, 2022

Add Iosevka from Iosevka Release v22.1.1

https://github.com/be5invis/Iosevka/releases/tag/v22.1.1

Keep in mind, patching Iosevka needs corrected fontforge.
But that also holds for the already present Iosevkas.

Probably this should be coupled with a general Iosevka update. Here just the Term Slab is added, the other two are untouched and an old revision!

Requirements / Checklist

What does this Pull Request (PR) do?

Add another Iosevka variant, next to the already present 'standard' and 'Term' ones.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes: #281 see comments in the end esp. for folder structure?

Screenshots (if appropriate or helpful)

@Finii Finii mentioned this pull request May 17, 2022
3 tasks
@Finii
Copy link
Collaborator Author

Finii commented Oct 7, 2022

Well, I am hesitant to add this. Because of the sheer volume of Iosevkas, probably.

But I believe the folder structure is ... not very useful. We bundle by weight and not by (sub)family/style.
Is this reasonable?

(Contrieved example:)

Iosevka/Regular/Iosevka-Regular.ttf
Iosevka/Regular/IosevkaSlab-Regular.ttf
Iosevka/Bold/Iosevka-Bold.ttf
Iosevka/Bold/IosevkaSlab-Bold.ttf

Would this not make more sense?

Iosevka/Standard/Iosevka-Regular.ttf
Iosevka/Standard/Iosevka-Bold.ttf
Iosevka/Slab/IosevkaSlab-Regular.ttf
Iosevka/Slab/IosevkaSlab-Bold.ttf

In this way users could choose which Family they want and have all weights of that family in one directory?

Also related:

Edit: Noticed the idea has already been voiced by @ChiefMikeK here #919 (comment)

@Finii
Copy link
Collaborator Author

Finii commented Jan 14, 2023

Difference between Iosevka and Iosevka Slab (Slab-serif), the normal Iosevka has no serifs.
Just for people like me that have no clue what the different Iosevkas are.

Peek 2023-01-14 14-34

Finii added a commit that referenced this pull request Apr 5, 2023
[why]
Both are full fledged families, one specifically for terminal, the other
not. Although it might be that people want both there is a likelyhood
that some just need one set.

Splitting these makes the individual release packages smaller and more
handable, and improves release workflow run time.

See also #803

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this pull request Apr 5, 2023
2 tasks
Finii added a commit that referenced this pull request Apr 5, 2023
[why]
Both are full fledged families, one specifically for terminal, the other
not. Although it might be that people want both there is a likelyhood
that some just need one set.

Splitting these makes the individual release packages smaller and more
handable, and improves release workflow run time.

[note]
Also fix RFN of mononoki en passant :-}
See comment on mononoki's RFN with the mononoki 1.6 update commit.

See also #803

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this pull request Apr 5, 2023
[why]
Both are full fledged families, one specifically for terminal, the other
not. Although it might be that people want both there is a likelyhood
that some just need one set.

Splitting these makes the individual release packages smaller and more
handable, and improves release workflow run time.

[note]
Also fix RFN of mononoki en passant :-}
See comment on mononoki's RFN with the mononoki 1.6 update commit.

See also #803

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@eggbean
Copy link

eggbean commented May 5, 2023

Please merge.

@Finii
Copy link
Collaborator Author

Finii commented May 7, 2023

Marked this for 3.1.0.

Du you think we need all the weights or can we drop some like ExtraLight or something?

@Finii Finii added this to the v3.1.0 milestone May 7, 2023
@Finii
Copy link
Collaborator Author

Finii commented May 7, 2023

Note to self: This must be completely redone

@Finii
Copy link
Collaborator Author

Finii commented May 7, 2023

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented May 7, 2023

Expanded copyall script.
Did all a-new. Force push.

@Finii Finii force-pushed the feature/Add-Iosevka-Term-Slab branch from 7333ce1 to 09c8315 Compare May 7, 2023 10:43
@eggbean
Copy link

eggbean commented May 7, 2023

Marked this for 3.1.0.

Du you think we need all the weights or can we drop some like ExtraLight or something?

I only use the standard one myself, but I also add Medium, Italic and Bold in case I need them. There are so many weights that I don't want to add them all, ha.

[why]
We have a lot of weights, probably not all useful for terminal usages.

[how]
Use more current fetching script and limit number of weights.
Also drop the directory substructure.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why]
New fonts do not get a in-repo release anymore.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii merged commit c48942d into master Nov 13, 2023
1 of 2 checks passed
@Finii Finii deleted the feature/Add-Iosevka-Term-Slab branch November 13, 2023 11:11
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Iosevka Term Slab
2 participants