Updated logic for when the resultSummary gets set and updated #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbertSmillbert
force-pushed
the
willbertsmillbert-Improvement_Test_Result_Array_Respect_Retries
branch
from
7e3ef18 to
c0527a1
Compare
willbertSmillbert
force-pushed
the
willbertsmillbert-Improvement_Test_Result_Array_Respect_Retries
branch
from
505506f to
7cc3d99
Compare
willbertSmillbert
deleted the
willbertsmillbert-Improvement_Test_Result_Array_Respect_Retries
branch
kalkun
reviewed
Aug 25, 2024
| if (resIndex > -1) { | ||
| for (const test of data.testSuite.tests) { | ||
| const testIndex = this.result[resIndex].testSuite.tests.findIndex( | ||
| (tes) => tes.name === test.name, |
There was a problem hiding this comment.
This also excludes tests to be added per project that it fails - is this intentional? I would like it to report per project that fails a particular test.
There was a problem hiding this comment.
yea this was an oversight
There was a problem hiding this comment.
hey @willbertSmillbert are you good to fix this?
There was a problem hiding this comment.
@ryanrosello-og the project thing appeared resolved by #171 I will have a look at the attachment issue tomorrow
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when using the reporter, that if the tests retry, the Results object would be erroneously populated. Refer to the below screenshot. In this example, there are 5 legitimate tests, with one of them retrying 5 times after failing, as you can see, the results array is getting pushed to each time, regardless if that result already exists. Further more, this is made even worse as each time the results array gets pushed to, the current testSuite state also gets pushed.
So instead of there being 1 test suite, 5 result getting pushed, there is the same test suite 5x being pushed
I decide to iterate over the existing results and then push to the array if the result does not exist, and modify the result if it does.
Note; a caveat to this implementation is that for failed tests, only the last instance of it failing will be in the results array
This saves having to do filtering later on, but I can update the logic slightly to push each time for test retries rather than replace