Make isDarwin check more robust #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had wondered about this approach but hadn't gotten around to investigating -- why not use |
There is some reasoning about the usage described here #79 (comment) :) . |
|
That's what I figured -- the goal is to check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided
isDarwincheck failed on my system becauseenvironmentattr does not exist inoptions.I assume that this happens because my setup is done with divnix/hive (https://github.com/divnix/hive), but I am not an expert :) (I see this PR as an opportunity to learn :); so close if I naivly do something totally wrong :) ).
Nevertheless, it is probably not a bad idea to only assume the most essential attrs to be present.