Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all functions from #205 except
round()
, since that one specifically accepts a keyword for its first argument. Probably I'll handle that one at some point in the future.I've opted to restructure
min
,max
andclamp
slightly here to reduce on repetition. These CSS functions differ only really in their return value; the system already didn't check for the units inside calculations, e.g. you'd never have an angle in awidth:
calculation, butwidth: calc(10deg)
highlights just fine.However caring about the return value means that e.g.
width: sin(10deg)
is not highlighted (sincesin()
returns a number, not a length) butline-height: sin(10deg)
does highlight.min()
,max()
andclamp()
fall in the bucket of functions that can return anything, and their return value depends on their arguments.