Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution] EUI Refresh Followup Pt. 1 (elastic#205990)
## Summary This is the first batch of work involving elastic#202052. It includes the following tasks: - [x] (Important) Review usage of "success" colors for positive, semantic intent.([details](elastic#202052 (comment))). - [x] (Important) Review and update color palette usage. ([details](#color-palettes)) - [x] (Important) Replace vis colors used outside of visualizations with color tokens . ([details](elastic#202052 (comment))) - [x] (Important) Replace custom colors with semantic tokens ([details](elastic#202052 (comment))) - [x] (Important) Replace color calculation functions with semantic tokens. ([details](elastic#202052 (comment))) - [x] Update tokens to use the new naming scheme. ([details](elastic#202052 (comment))) ### What changed? Broadly, these changes involve two main areas: Exception Lists and the Rule Creation form (specifically: the EQL query bar and the "time" inputs (Suppression Duration, Interval, Lookback)). I also found an unused component, and fixed a minor UI bug with Exception Comments. Screenshots (before and after, and with both themes) are included below. Also: as a majority of these components' usage of theme variables is done with `@styled-components`, and we are transitioning away from that toward `@emotion`, I also opted to remove usages of `@styled-components` wherever possible, as that change was negligible in comparison with the theming changes. If a file being changed included references to static eui theme variables, e.g. `euiThemeVars`, those were removed as well (but many are still outstanding). ### Screenshots __NOTE__: Most of the "Before" screenshots were taken from a cluster using the Borealis theme. <details> <summary> <h3>Rule Exceptions Tab</h3> </summary> <kbd> <h3>Before</h3> <img width="1594" alt="Rule Exceptions - Before" src="https://github.com/user-attachments/assets/56feb5e8-b5ec-4bdc-9372-968056e6bca3" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="805" alt="Rule Exceptions - After (Amsterdam)" src="https://github.com/user-attachments/assets/a6ab3d47-acc7-4eb6-8a0c-bd9ccafc2021" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="805" alt="Rule Exceptions - After (Borealis)" src="https://github.com/user-attachments/assets/9fbd8a17-0afb-4ccc-95ea-5bab4da5b254" /> </kbd> </details> <details> <summary> <h3>Shared Exception Lists</h3> </summary> <kbd> <h3>Before</h3> <img width="1594" alt="Shared Exception Lists - Before" src="https://github.com/user-attachments/assets/b2a69f9c-4892-4732-a2e1-e167461680d1" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="805" alt="Shared Exception Lists - After (Amsterdam)" src="https://github.com/user-attachments/assets/1aea0dff-97ee-4482-9a66-38c4be2baea8" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="805" alt="Shared Exception Lists - After (Borealis)" src="https://github.com/user-attachments/assets/76be9446-17fb-451d-b15a-99166cb1f588" /> </kbd> </details> <details> <summary> <h3>Shared List Details</h3> </summary> <kbd> <h3>Before</h3> <img width="1594" alt="Shared List Details - Before" src="https://github.com/user-attachments/assets/5eeec91d-ea96-4e3c-8c7d-b5e6bb8bf35a" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="805" alt="Shared List Details - After (Amsterdam)" src="https://github.com/user-attachments/assets/5229b850-356c-40e7-80f1-d32156f97a56" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="805" alt="Shared List Details - After (Borealis)" src="https://github.com/user-attachments/assets/81219613-c329-48f8-8fd3-857207d0ada0" /> </kbd> </details> <details> <summary> <h3>EQL Query Input</h3> </summary> <kbd> <h3>Before</h3> <img width="1085" alt="EQL Bar - Before" src="https://github.com/user-attachments/assets/b19cf18b-a5d2-4001-bebc-9154af8e9b43" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="1085" alt="EQL Bar - After (Amsterdam)" src="https://github.com/user-attachments/assets/70911ad2-9e52-4b65-b305-cd90a6be1fd2" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="1085" alt="EQL Bar - After (Borealis)" src="https://github.com/user-attachments/assets/92a789d0-fffa-483c-bcb2-fc02b5e8ce10" /> </kbd> </details> <details> <summary> <h3>Suppression Fields</h3> </summary> <kbd> <h3>Before</h3> <img width="1085" alt="Suppression Fields - Before" src="https://github.com/user-attachments/assets/458c3464-0eba-47d4-abbe-8de0b333b8ec" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="1085" alt="Suppression Fields - After (Amsterdam)" src="https://github.com/user-attachments/assets/b6fb67b0-7908-4fe8-9e02-d9e14c8f97c5" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="1085" alt="Suppression Fields - After (Borealis)" src="https://github.com/user-attachments/assets/f48c24a5-50ea-41fd-af45-b3d32f20921b" /> </kbd> </details> <details> <summary> <h3>Suppression Fields (Disabled)</h3> </summary> <kbd> <h3>Before</h3> <img width="1085" alt="Suppression Fields (Disabled) - Before" src="https://github.com/user-attachments/assets/e60aa561-d8ce-4b23-8694-e6443ad37c16" /> </kbd> <kbd> <h3>After (Amsterdam)</h3> <img width="1085" alt="Suppression Fields (Disabled) - After (Amsterdam)" src="https://github.com/user-attachments/assets/45277962-482d-484c-b8bd-3a587b7c16d1" /> </kbd> <kbd> <h3>After (Borealis)</h3> <img width="1085" alt="Suppression Fields (Disabled) - After (Borealis)" src="https://github.com/user-attachments/assets/69f6217b-a2c2-4c6a-be9e-80dfd0a4e5f1" /> </kbd> </details> <details> <summary> <h3>Exception Comments UI Bug</h3> </summary> <kbd> <h3>Before</h3> <img width="805" alt="Comments UI Bug - Before" src="https://github.com/user-attachments/assets/652d35fa-8ff2-4850-a9a4-79cec3b4b698" /> </kbd> <kbd> <h3>After</h3> <img width="805" alt="Comments UI Bug - After" src="https://github.com/user-attachments/assets/a8cc1cd6-b25f-4694-a479-c35f45eae6aa" /> </kbd> </details> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
- Loading branch information