Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support prerelease #83

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dumptruckman
Copy link

PR Notes

  • Reviewed Checks: Verified output of Integration Tests
  • Have set labels for release level

I did not run integration tests locally as they did not work. Unsure how to get them to run. This could use some documentation but I wanted to get a feel for your thoughts on it. I suspect this hasn't been supported yet due there being no standard definition of prerelease versioning that can be followed. This PR takes an opinionated approach using 1.0.0 -> 1.0.0-pre -> 1.0.0-pre.1 -> 1.0.0-pre.2 etc. It also bumps the main version separately so the PR labels can be combined to bump both at the same time.

Fixes #76.

@dumptruckman
Copy link
Author

After testing this in action a little bit it seems that there's still some work to be done. Getting from an existing prerelease version like 4.2.1-pre to 4.2.1-pre.1 is not working yet.

@dumptruckman
Copy link
Author

Well, I got this working how we're trying to use it. I think maybe the release it fetches should be based on whether it's doing a prerelease or not though. It would be nice to have it do a full change log to the last non-prerelease version when doing a non-prerelease release.

@hermanbanken
Copy link

Would be cool if this was added 😄

@Kripu77
Copy link

Kripu77 commented Jun 25, 2024

Would be cool if this was added 😄

@rymndhng would be great if this could be added to the project.

@Kripu77
Copy link

Kripu77 commented Jun 25, 2024

PR Notes

  • Reviewed Checks: Verified output of Integration Tests
  • Have set labels for release level

I did not run integration tests locally as they did not work. Unsure how to get them to run. This could use some documentation but I wanted to get a feel for your thoughts on it. I suspect this hasn't been supported yet due there being no standard definition of prerelease versioning that can be followed. This PR takes an opinionated approach using 1.0.0 -> 1.0.0-pre -> 1.0.0-pre.1 -> 1.0.0-pre.2 etc. It also bumps the main version separately so the PR labels can be combined to bump both at the same time.

Fixes #76.

Hey mate, based on SemVer principles would you consider adding generic pre-labels for example:

  • alhpa
  • beta
  • rc

And, let the user decide the pre-release label based on the labels attached with the PR?

@afgarcia86
Copy link

Any reason this can't be merged?

@Kripu77
Copy link

Kripu77 commented Sep 5, 2024

@afgarcia86
Seems like this repo isn't being maintained anymore.

@afgarcia86
Copy link

afgarcia86 commented Sep 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing creation of a pre-release version and pre-release suffix
4 participants