-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support prerelease #83
base: master
Are you sure you want to change the base?
Conversation
After testing this in action a little bit it seems that there's still some work to be done. Getting from an existing prerelease version like |
Well, I got this working how we're trying to use it. I think maybe the release it fetches should be based on whether it's doing a prerelease or not though. It would be nice to have it do a full change log to the last non-prerelease version when doing a non-prerelease release. |
Would be cool if this was added 😄 |
@rymndhng would be great if this could be added to the project. |
Hey mate, based on SemVer principles would you consider adding generic pre-labels for example:
And, let the user decide the pre-release label based on the labels attached with the PR? |
Any reason this can't be merged? |
@afgarcia86 |
Yea I ended up going with ***@***.*** that doesn’t do
the tagging and release but has the dynamic versioning I needed.
Best Regards,
Andres Garcia
Software Engineer
<http://www.andresthegiant.com>http://www.andresthegiant.com
703.389.1081
…On Wed, Sep 4, 2024 at 8:58 PM Kripu Khadka ***@***.***> wrote:
@afgarcia86 <https://github.com/afgarcia86>
Seems like this repo isn't being maintained anymore.
—
Reply to this email directly, view it on GitHub
<#83 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3QMJN3DKESDM2KW23FKMTZU6UCPAVCNFSM6AAAAAAVG5ZFIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGM4TMOJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
PR Notes
I did not run integration tests locally as they did not work. Unsure how to get them to run. This could use some documentation but I wanted to get a feel for your thoughts on it. I suspect this hasn't been supported yet due there being no standard definition of prerelease versioning that can be followed. This PR takes an opinionated approach using
1.0.0
->1.0.0-pre
->1.0.0-pre.1
->1.0.0-pre.2
etc. It also bumps the main version separately so the PR labels can be combined to bump both at the same time.Fixes #76.