Remove the unknown trophies (as don't look good) #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhavberi is attempting to deploy a commit to the ryo-ma's Team Team on Vercel. A member of the Team first needs to authorize it. |
|
@alexcastrodev Requesting your review and suggestions. |
|
@ryo-ma introduces unknows, he knows better if makes sense. In my oppinion for this PR, you are not removing, but filtering. if we need to remove ( i dont know if it is necessary ), we should remove permanently. |
|
Yeah, the trophies with 0 points (given the rank of Unknown) would not show on user profiles by default. Here, the meaning of remove meant from user badges. |
|
Also, what kind of tests are missing? |
|
how can i contribute , iam new to git |
|
i am not getting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unknown ranked trophies from the permanent trophies, as they don't look good on a profile...