Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.bash to use the new release URL format #8

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

pedropombeiro
Copy link
Contributor

@elementalvoid
Copy link

From personal experience, this will break old versions and folks still depend on those old versions even if while they might get the updated plugin.

I suggest adding a semver comparison and toggling the new/old URL based on the version where the change happened. There's even a commonly used verlte function in use in a number of asdf plugins. Here's an example in one of my plugins: https://github.com/elementalvoid/asdf-nova/blob/master/bin/install#L38 (and the function in utils.sh).

@kr3cj
Copy link

kr3cj commented Sep 23, 2024

I don't believe this would work for macs as those downloads now use macos as opposed to darwin. See #9

@pedropombeiro
Copy link
Contributor Author

I don't believe this would work for macs as those downloads now use macos as opposed to darwin. See #9

Good point. I've improved the script to work on macos too:

image

@sshishov
Copy link

sshishov commented Oct 9, 2024

It would be nice to have it merged as we cannot install the viddy now

@ryodocx
Copy link
Owner

ryodocx commented Oct 9, 2024

Sorry for the delayed reply.

@ryodocx ryodocx merged commit a969786 into ryodocx:main Oct 9, 2024
4 checks passed
@ryodocx
Copy link
Owner

ryodocx commented Oct 9, 2024

close #9

@sshishov
Copy link

@ryodocx thank you very much, tested, everything works as expected, was able to install 1.2.0 version using asdf and default plugin repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants