bug fix : wait one second to get title when new target create

ryuken73 · Jul 17, 2020 · fab8cc3 · fab8cc3
1 parent 010f4b2
commit fab8cc3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/browser/Browser.js b/app/browser/Browser.js
@@ -159,7 +159,9 @@ class Browser extends EventEmitter {
             }
             const requestIndex = page.requestMap.get(request);
             if(requestIndex === undefined) {
-                console.error(`response which cannot be mapped with request Map(not added) arrived :  Map[${pageIndex}], ${response.url()}`);
+                console.error(`response which cannot be mapped with request Map(not added) arrived. reload :  Map[${pageIndex}], ${response.url()}`);
+                await page.reload();
+                return;
             }
             const requestFname = getFirstStringBySep({str:getLastStringBySep({str: requestUrl, sep: '/'}), sep:'?'});
             const metadata = await imageUtil.getMetadata(buff);
@@ -271,7 +273,13 @@ class Browser extends EventEmitter {
                 await page.setRequestInterception(false);
                 console.log(`request resumed![${pageIndex}]`);
             },100)
-
+            if(title === ''){
+                console.log('title is empty.');
+                setTimeout(async () => {
+                    const title = await page.title();
+                    this.emit('titleChanged', {pageIndex, title});
+                },1000)
+            }
         });
 
         this._setDefaultBrowserEventHandler();

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "electron-image-downloader",
   "productName": "Image-Downloader",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Web browser based image downloader using puppeteer",
   "scripts": {
     "build": "concurrently \"yarn build-main\" \"yarn build-renderer\"",