QJsonModel enum flags defined and renamed for consistency

s-daveb · May 11, 2024 · fd29e49 · fd29e49
1 parent 1742000
commit fd29e49
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -13,7 +13,7 @@ disable_tests_if_subproject()
 #git_setup_submodules()
 
 project(QJsonModel
-	VERSION 0.0.5
+	VERSION 0.0.6
 	LANGUAGES C CXX
 	# Save this for later:
 	# HOMEPAGE_URL <URL>

diff --git a/include/QJsonModel.hpp b/include/QJsonModel.hpp
@@ -45,31 +45,35 @@ class QJsonModel : public QAbstractItemModel {
     public:
 	// clang-format off
 	enum FieldPermissions : unsigned char {
-		ReadOnly      = 0b0000,
-		WritableValue = 0b0001,
-		WritableKey   = 0b0010
-	}; // clang-format on
+		kReadOnly      = 0b0000,
+		kWritableValue = 0b0001,
+		kWritableKey   = 0b0010
+	};
+	enum ErrorFlag : bool {
+		kSuccess = false,
+		kError = true,
+	};
+	// clang-format on
 
 	explicit QJsonModel(
 	    QObject* parent = nullptr,
-	    FieldPermissions permissions = WritableValue
+	    FieldPermissions permissions = kWritableValue
 	);
 	QJsonModel(
 	    const QString& fileName, QObject* parent = nullptr,
-	    FieldPermissions permissions = WritableValue
+	    FieldPermissions permissions = kWritableValue
 	);
 	QJsonModel(
 	    QIODevice* device, QObject* parent = nullptr,
-	    FieldPermissions permissions = WritableValue
+	    FieldPermissions permissions = kWritableValue
 	);
 	QJsonModel(
 	    const QByteArray& json, QObject* parent = nullptr,
-	    FieldPermissions permissions = WritableValue
+	    FieldPermissions permissions = kWritableValue
 	);
 
 	~QJsonModel() override;
 
-	using ErrorFlag = bool;
 	ErrorFlag load(const QString& fileName);
 	ErrorFlag load(QIODevice* file);
 	ErrorFlag loadJson(const QByteArray& json);