allow character loggers in as_LogEvent.list

s-fleck · Sep 5, 2022 · c725c92 · c725c92
1 parent cacbfd8
commit c725c92
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/R/LogEvent.R b/R/LogEvent.R
@@ -55,7 +55,7 @@ LogEvent <- R6::R6Class(
       msg = NA,
       ...
     ){
-      assert(inherits(logger, "Logger"), "Logger must be a <Logger> object, not a", class_fmt(logger))
+      assert(inherits(logger, "Logger"), "Logger must be a <Logger> object, not a ", class_fmt(logger))
 
       # assign has less overhead than [[ and event creation needs to be as fast
       # as possible
@@ -157,6 +157,8 @@ as_LogEvent.list <- function(x, ...){
 
   if (is.null(x[["logger"]])){
     x[["logger"]] <- get_logger()
+  } else if (is.character(x[["logger"]])){
+    x[["logger"]] <- get_logger(x[["logger"]])
   }
 
   # smartly rename timestamp fields from ElasticSearch/Logstash

diff --git a/cran-comments.md b/cran-comments.md
@@ -3,3 +3,5 @@
 0 errors | 0 warnings | 0 note
 
 Rebuild docs for R 4.2.0
+
+*resubmission* to fix minor error when priting loggers