Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set X-Message-Id with SentMessage::setMessageId #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jameswagoner
Copy link

@jameswagoner jameswagoner commented May 24, 2024

WHAT

Propose using setMessageId() instead of headers for X-Message-Id

WHY

Event::listen(function (MessageSent $event) {
    // when sendgrid ID set with headers
    $sendgridId = $event->message->getHeaders()->getHeaderBody('x-sendgrid-message-id');

    // when sendgrid ID set with setMessageId()
    $sendgridId = $event->sent->getMessageId();
});

@parkourben99
Copy link
Contributor

This would be a breaking change for anyone currently using this header.

@jameswagoner
Copy link
Author

jameswagoner commented May 26, 2024 via email

@jameswagoner
Copy link
Author

added header and test assertion back in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants