-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USERNAME
and EMAIL
env variables
#75
Conversation
Added support for a custom username and email to be used in the autogenerated commit. Just set `USERNAME` and `EMAIL` respectively in the env variables.
Hiya, thanks for the contribution, this is a nice addition. Before we can get this merged in though, we need to add a few things to this PR:
I can help you with any of the above or do it myself, but happy to let you have a go if you'd prefer to do it? |
I've updated the readme, regenerated the action code, and added a unit test. Not too familiar with typescript (or even javascript) so I might be missing something. |
@s0 bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks so much for this contribution, and for the docs and tests too, and sorry for the delayed review. I have some comments regarding naming, but other than this I think it's good to go! Thanks!
(also sorry for not including these change requests in the first review, I had some time to think about the naming and only remembered after I saw it in my notifications again) |
- The `USERNAME` and `EMAIL` env variables have been renamed `COMMIT_NAME` and `COMMIT_EMAIL` respectively. - Updated readme to reflect this. - Fixed the file name of the username-email spec.
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added support for a custom username and email to be used in the autogenerated commit. Just set
USERNAME
andEMAIL
respectively in the env variables.Context
The autogenerated commit this action produces always uses the username and email of the pusher. This commit adds support for changing these variables using the
USERNAME
andEMAIL
environment variables. My particular use case was to mark these autogenerated commits as being created by the github-actions bot:Checklist