Upgrade node to 16 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0
approved these changes
Oct 23, 2022
auto-merge was automatically disabled
October 23, 2022 18:39
Head branch was pushed to by a user without write access
|
@s0 Not sure why tests are breaking now, Do you have any suggestions or thoughts? |
auto-merge was automatically disabled
November 3, 2022 21:33
Head branch was pushed to by a user without write access
Codecov Report
@@ Coverage Diff @@
## develop #80 +/- ##
========================================
Coverage 89.94% 89.94%
========================================
Files 1 1
Lines 189 189
Branches 37 37
========================================
Hits 170 170
Misses 14 14
Partials 5 5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for doing this! :) Also needed to update the package-lock.json, but i added that and rebased, so this should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Node 12 is dead since April 2022, GitHub action is currently giving a warning and asking for an upgrade.
Checklist