Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch get_face_single() to order from largest to smaller #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flesler
Copy link

@flesler flesler commented Jul 18, 2023

Similar to my PR at roop s0md3v/roop#731

Many times I wished the order was closer to what I expected. I tried to find concrete docs on the faces' bbox but couldn't. I did find this example which seems good enough

The current implementation is picking whichever is more to the left. I think a better default (given one HAS to be chosen) is grabbing the largest one. That's usually the one closer to the viewer and the main point of focus.

@2blackbar
Copy link

When this will be merged ?

@s0md3v
Copy link
Owner

s0md3v commented Aug 21, 2023

Wouldn't it cause confusion when there are faces that are comparable in size? Like in a group photo?

@flesler
Copy link
Author

flesler commented Aug 21, 2023

It's better sometimes, worse sometimes IMO. Maybe it can be a setting, as in which sorting "algorithm" to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants