Added writing of genesis.Alloc on bootstrap
#15
Conversation
core/blockchain.go
Outdated
| @@ -406,6 +406,34 @@ func NewBlockChain(db ethdb.Database, cacheConfig *CacheConfig, genesis *Genesis | |||
| } | |||
| } | |||
|
|
|||
| if bc.logger != nil && bc.CurrentBlock().Number.Uint64() == 0 { | |||
There was a problem hiding this comment.
Hm, so we want to only emit this event on the first sync? Asking because you have the currentBlock == 0 check
There was a problem hiding this comment.
I'm not sure we have the state that tells us if it's a first sync or not. I would like to have OnGenesisBlock called only once indeed!
…ll also fill the missing value now
maoueh
force-pushed
the
sf/feature/genesis-alloc-on-init
branch
from
24e52d7
to
0856f27
Compare
|
Updated with the fact that genesis state spec is already written, only modified |
core/genesis.go
Outdated
| alloc = genesis.Alloc | ||
| } else { | ||
| return errors.New("not found") | ||
| return nil, true, err |
There was a problem hiding this comment.
Do we really need found? a nil alloc could mean not found
core/genesis.go
Outdated
| } | ||
|
|
||
| if !found { | ||
| return nil |
There was a problem hiding this comment.
We used to return errors.New("not found") in this case. What's the reason for this behavior change?
There was a problem hiding this comment.
That's was a mistake indeed, I'll revert this
maoueh
changed the title
genesis.Alloc on bootstrap, geth init also fills the missing valuegenesis.Alloc on bootstrap
No description provided.