Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile not capturing all the sfs unittests #450

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

giubacc
Copy link

@giubacc giubacc commented Apr 18, 2023

Dockerfile was capturing unittest_rgw_sfs* pattern but not unittest_rgw_s3gw*

Fixes: https://github.com/aquarist-labs/s3gw/issues/447
Signed-off-by: Giuseppe Baccini giuseppe.baccini@suse.com

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

Dockerfile was capturing unittest_rgw_sfs* pattern but not unittest_rgw_s3gw*

Fixes: https://github.com/aquarist-labs/s3gw/issues/447
Signed-off-by: Giuseppe Baccini <giuseppe.baccini@suse.com>
@giubacc giubacc self-assigned this Apr 18, 2023
@giubacc giubacc added this to the v0.15.0 milestone Apr 18, 2023
@giubacc giubacc requested review from 0xavi0 and jecluis April 18, 2023 15:32
Copy link
Contributor

@jecluis jecluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, assuming only sfs tests are built.

@giubacc
Copy link
Author

giubacc commented Apr 19, 2023

Seems okay, assuming only sfs tests are built.

this is intended to copy both: unittest_rgw_sfs_* and unittest_rgw_s3gw_*, am I correct assuming this?

@giubacc giubacc requested a review from m-ildefons April 19, 2023 10:25
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-ildefons
Copy link
Contributor

Up until now we've only been building the unittest_rgw_{sfs,s3gw}_* tests, so this PR is fine. There exist however a lot more unit tests that would fit this pattern. For the sake of build speed and keeping focus on SFS, we should avoid building those. But that is not somethings this Dockerfile gets to decide, that is done with the qa/rgw/store/sfs/build-radosgw.sh script.

Unfortunately, I don't see an automated reliable way to pick out the right unit tests of all the unit tests, so for the time being we'll have to maintain a list or a naming pattern for the ones that we care about.

@giubacc giubacc merged commit 87fd1e3 into s3gw-tech:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: s3gw release.yaml - s3gw-unittests not working
3 participants