Fixes s3cmd#1197 - add custom header for s3cmd mb #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also needed '--add-header' at the bucket creation and added codes myself. However, in the end, I found this commit which was exactly same of what I did. I totally agreed this patch and would proceed review to merge. |
|
Merged, thank you for your contribution! Btw, if there are specific instructions to configure s3cmd to be used with Cloudian, don't hesitate to add the info to the following wiki page: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Cloudian Hyperstore S3 software stack (www.cloudian.com) bucket creation can take an extra header to specify a storage policy id.
s3cmd mbsilently ignores custom headers as specified with the--add-headeroption.s3cmd and S3/S3.py updated to pass custom header to the S3 stack.