-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FIPS support #1233
Add FIPS support #1233
Conversation
This should fix this issue: #1005 |
Thank you for your PR, I never heard about this parameter for hashlib but it is awesome to unblock people in such a case. I notice here (https://code.djangoproject.com/ticket/28401) that it is only available since python 3.9 or on Fedora/redhat distributions. But still better than nothing. I would suggest the following improvement to your PR:
|
Done. md5 is moved to BaseUtils. |
@fviard Is this change OK for submission? |
Merged, thank you very much and sorry for the delay. I think that I did not notice that you pushed the requested changes. Btw, I will modify further the code in another commit, because as the "usedforsecurity" will be available upstream, it will be good to have that as a default case. |
When is the plan to release it? how can I consume this fix? thanks |
@fviard glad this is fixed but I couldn't find a release post october 3rd where this fix is available https://github.com/s3tools/s3cmd/releases |
When FIPS mode is enabled, s3cmd raises a ValueError exception with the message 'digital envelope routines: EVP_DigestInit_ex] disabled for FIPS' (see below). This change will make s3cmd compatible with FIPS mode.