Fixes #936 - Fix setacl command exception #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grantee.display_name may not be initialize for some Grantee types, most notably for xsi:type="Group". However, tolower() is called on this attribute in ACL.revoke(), raising unhandled AttributeError. To prevent it, let's change default value of Grantee.display_name to empty string with almost identical semantical value, but allowing lower() call to succeed. I also applied the Boolean Distributive law to simplify condition in ACL.revoke().
|
@mouchar Thank you very much for having investigating this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grantee.display_name may not be initialize for some Grantee types,
most notably for xsi:type="Group".
However, tolower() is called on this attribute in ACL.revoke(),
raising unhandled AttributeError. To prevent it, let's change
default value of Grantee.display_name to empty string with almost
identical semantical value, but allowing lower() call to succeed.
I also applied the Boolean Distributive law to simplify condition
in ACL.revoke().