Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added automatic import of cesium css #9

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

jfayot
Copy link
Contributor

@jfayot jfayot commented Sep 12, 2024

This is a proposal to add Cesium css (Viewer's as well as CesiumWidget's) automatically by the plugin.
This allows to get rid of imports in code.
Not done yet, but this could be deactivated by an additional option if you think it's better.

@jfayot
Copy link
Contributor Author

jfayot commented Sep 12, 2024

I just realized I forgot to update the REAME...

Copy link
Contributor Author

@jfayot jfayot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you update the Chineese version if you accept this PR...

@s3xysteak
Copy link
Owner

Looks good to me but I think it will break apps using Cesium version 1.96 and earlier. Could you add an option css, which defaults to false, and enable this feature by setting it to true?

plugins: [
  cesium({
    css: true
  })
]

So that I can release it as a patch. We can pick a good day to release a minor version which using css: true as the default.

@jfayot
Copy link
Contributor Author

jfayot commented Sep 16, 2024

You're right ! Done

@jfayot
Copy link
Contributor Author

jfayot commented Sep 16, 2024

In the meantime, I've reverted the examples. We shall update them when defaulting css to true ?

@s3xysteak
Copy link
Owner

I can update them when needed. Thanks for your contribution! I think it will be released in a few days.

src/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@s3xysteak s3xysteak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it has been ready to be merged. If you have any more issues plz remind me! It will be merged and released tomorrow.

@s3xysteak s3xysteak merged commit b8fa90f into s3xysteak:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants