-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added automatic import of cesium css #9
Conversation
I just realized I forgot to update the REAME... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let you update the Chineese version if you accept this PR...
Looks good to me but I think it will break apps using Cesium version 1.96 and earlier. Could you add an option plugins: [
cesium({
css: true
})
] So that I can release it as a patch. We can pick a good day to release a minor version which using |
You're right ! Done |
In the meantime, I've reverted the examples. We shall update them when defaulting css to true ? |
I can update them when needed. Thanks for your contribution! I think it will be released in a few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it has been ready to be merged. If you have any more issues plz remind me! It will be merged and released tomorrow.
This is a proposal to add Cesium css (Viewer's as well as CesiumWidget's) automatically by the plugin.
This allows to get rid of imports in code.
Not done yet, but this could be deactivated by an additional option if you think it's better.